Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change message on strictEqual #16840

Closed
wants to merge 1 commit into from
Closed

test: change message on strictEqual #16840

wants to merge 1 commit into from

Conversation

keldorus
Copy link
Contributor

@keldorus keldorus commented Nov 6, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Nov 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11253/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 7, 2017
@keldorus @Trott
test: improve message in test-fs-readfile-pipe-large
9a1565e 
Improve assertion message by including expected and actual values.

PR-URL: nodejs#16840
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 7, 2017

Landed in 9a1565e.
Thanks for the contribution! 🎉

@Trott Trott closed this Nov 7, 2017
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
@keldorus @cjihrig
test: improve message in test-fs-readfile-pipe-large
a409b87 
Improve assertion message by including expected and actual values.

PR-URL: nodejs#16840
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@cjihrig cjihrig mentioned this pull request Nov 7, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@keldorus @MylesBorins
test: improve message in test-fs-readfile-pipe-large
ec4c3f5 
Improve assertion message by including expected and actual values.

PR-URL: #16840
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@keldorus @joyeecheung @Trott @addaleax @lpinca @targos @gireeshpunathil @mscdex @MylesBorins @nodejs-github-bot