Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.9.0 proposal #16630

Merged
merged 98 commits into from
Oct 31, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
98 commits
Select commit Hold shift + click to select a range
0d7e4d2
deps: update npm to 5.5.1
MylesBorins Oct 30, 2017
f00ba6b
src: fix http2 debug build errors
danbev Oct 24, 2017
8fd75fb
util: graduate TextEncoder/TextDecoder, tests
jasnell Oct 2, 2017
3a230b4
lib: internal/errors should not be executable
maclover7 Oct 21, 2017
3638694
http2: fix errors in debug statements
apapirovski Oct 21, 2017
b5c6d59
build,win: set /MP separately in Debug and Release
seishun Oct 23, 2017
22ec800
build: do not include deleted directory
maclover7 Oct 22, 2017
f0576c5
src: remove unused include in tty_wrap.h
danbev Oct 16, 2017
9bca620
src: remove empty comment in node_http2.h
danbev Oct 23, 2017
ac02a0b
module: support custom paths to require.resolve()
cjihrig Apr 25, 2016
e6e99eb
http2: do not allow socket manipulation
apapirovski Oct 20, 2017
04fac61
doc: improve http2 documentation
jsha Oct 21, 2017
3d499b3
tools: introduce [email protected]
watilde Apr 30, 2017
8d62116
tools: introduce remark-preset-lint-node
watilde Apr 30, 2017
3522e76
tools: use remark-preset-lint-node in .remarkrc
watilde Apr 30, 2017
ea415a6
tools: add lint-md command in Makefile
watilde Apr 30, 2017
9185cfe
build: add lint-md-build
watilde May 22, 2017
31f54e5
tools: add make lint-md-clean
watilde May 26, 2017
3b64fa4
build: fix npm install with --shared
bnoordhuis Oct 24, 2017
465540c
src: destroy inspector agent before context
ofrobots Oct 25, 2017
568d614
test: allow tests to pass without internet
danbev Oct 17, 2017
2c2b658
http2: fix mapToHeaders() with single string value
jinwoo Oct 24, 2017
fe5d453
doc, win: remove note about resize
bzoz Oct 26, 2017
ee40368
src: make header file self-contained
joyeecheung Oct 26, 2017
0a1f7fe
build: skip bin override on windows
digitalinfinity Oct 21, 2017
e80d878
tools: no trailing slash in ignore patterns
refack Oct 21, 2017
02ac8ba
test: change tmp directories prefix
refack Oct 21, 2017
a763fcd
build: improve `make clean`
refack Oct 22, 2017
754df71
https: refactor to use http internals
bengl Oct 23, 2017
83902e6
doc: add multiple build guide to benchmarking doc
Oct 11, 2017
4ba06d0
doc: add dot in documentations
erwinwahyura Oct 27, 2017
0a5a2c4
src: fix vm module for strict mode
fhinkel Oct 25, 2017
977fe22
test: add failing vm tests to known_issues
targos Oct 23, 2017
aaacddb
test: use fixtures module in tls-handshake-error
Oct 6, 2017
a7540d5
doc: remove http2 pushStream weight option
sebdeckers Oct 24, 2017
525700b
test: skip test-process-config if no config.gypi
gibfahn Oct 20, 2017
a0fcd4d
test: use common.buildType in repl-domain-abort
Trott Oct 26, 2017
ea32d0e
test: use process.features.debug in common module
Trott Oct 26, 2017
24fd8ff
http2: adjust stream buffer size
apapirovski Oct 24, 2017
b1e2a38
tools: fix cpplint.py when path contains non-ascii
sharkfisher Oct 6, 2017
e683077
module: fix hook module CJS dependency loading
guybedford Oct 22, 2017
415fb56
module: fix extension lookups for top-level main
guybedford Oct 26, 2017
ec51688
src: use V8 function to get Module Namespace
bmeck Oct 17, 2017
aea09da
test: include values in assertion messages
nhoel Oct 6, 2017
03b233e
doc: fix CHANGELOG_V8 indentation
maclover7 Oct 26, 2017
0460210
doc: add note to releases.md
maclover7 Oct 26, 2017
a194d83
src: use maybe versions of methods
Oct 6, 2017
604ab12
test: show values instead of assertion message
dinophile Oct 6, 2017
b4af922
test: imporove assert messages
Oct 6, 2017
fe9cca2
test: use fixtures module
scottjbeck Oct 6, 2017
01058c4
test: use fixtures module in test-fs-realpath.js
RaphaelRheault Oct 6, 2017
4f47e2d
test: increase fs.exists coverage
NigelKibodeaux Oct 25, 2017
2e1b45d
test: add details in assertions in test-vm-context
burgerboydaddy Oct 10, 2017
ce07cbe
test: use fixtures module
Oct 6, 2017
d185bfd
test: replace fixturesDir in test-tls-connect
Oct 6, 2017
c8a3b2d
build: run linter before running tests
joyeecheung Oct 18, 2017
bac2aff
test: include actual value in assertion message
mattcan Oct 6, 2017
77c02aa
src: use uv_stream_t, not uv_stream_s
bnoordhuis Oct 26, 2017
3a54bb5
src: remove superfluous HandleScope
bnoordhuis Oct 25, 2017
6ac7eef
src: move handle properties to prototype
bnoordhuis Oct 25, 2017
0510f42
test: update test-timers-block-eventloop.js
zhangzifa Oct 19, 2017
1b08ae8
doc: http2.connect accepts net & tls options
apapirovski Oct 28, 2017
e592c32
http2: fix several timeout related issues
apapirovski Oct 25, 2017
98b9705
http2: simplify mapToHeaders, stricter validation
apapirovski Oct 28, 2017
b93275e
doc: slightly relax 50 character rule
jasnell Oct 26, 2017
d5891b5
tools: replace loop with padStart
tniessen Oct 15, 2017
3d8a7e9
tools: modernize license2rtf
tniessen Oct 15, 2017
8c0c456
lib: setup IPC channel before console
seishun Oct 27, 2017
a628455
test: add block scoping to test-assert-deep
Trott Oct 26, 2017
528edb2
build: ignore empty folders in test-addons-napi
addaleax Oct 22, 2017
95a61cb
http2: fix stream reading resumption
apapirovski Oct 29, 2017
63e33ac
build: make doc target quiet
danbev Oct 26, 2017
d576e17
build: make test-doc and lint addon docs
joyeecheung Oct 22, 2017
e5c2059
doc: make default values and periods consistent
matejkrajcovic Oct 27, 2017
a6b3cd8
doc: more accurate zlib windowBits information
addaleax Oct 26, 2017
55ba1d4
util: expand test coverage for util.deprecate
akaila Oct 18, 2017
6be4942
lib: move duplicate spliceOne into internal/util
starkwang Oct 15, 2017
fdc072b
doc: fix inconsistent server.listen documentation
mgjm Oct 6, 2017
96e8250
lib: use destructuring for some constants
starkwang Oct 7, 2017
d6619b9
doc: document missing error codes
gnbezerra Sep 3, 2017
5787f53
deps: cherry-pick 2c75616 from upstream V8
targos Oct 25, 2017
7bdb8db
deps: cherry-pick 676c413 from upstream V8
targos Oct 25, 2017
ad69207
deps: cherry-pick e0d64dc from upstream V8
targos Oct 25, 2017
9bea207
child_process: fix memory leak in .fork()
bnoordhuis Sep 29, 2017
87fd5b7
lib: move _stream_wrap into internals
addaleax Oct 12, 2017
ab0d7a6
lib: refactor wrap_js_stream for ES6/readability
addaleax Oct 12, 2017
bf2564d
deps: V8: backport b1cd96e from upstream
ofrobots Oct 18, 2017
2ea25ad
inspector: track async stacks when necessary
ofrobots Oct 18, 2017
889f42a
test: remove empty comments in http2 tests
gibfahn Oct 30, 2017
5390d7e
http2: move uv_prepare handle to `Http2Session`
addaleax Oct 24, 2017
e578268
src: add `InternalCallbackScope` util constructor
addaleax Oct 24, 2017
56dd734
http2: track async state for sending
addaleax Oct 24, 2017
bfc1ad0
http2: remove unused assignment
addaleax Oct 24, 2017
54ebf91
http2: make sessions garbage-collectible
addaleax Oct 24, 2017
4d9c1be
doc: add Gibson Fahnestock to Release team
gibfahn Oct 30, 2017
3454c82
doc: add license information for remark-cli
MylesBorins Oct 31, 2017
f76ce0a
2017-10-31, Version 8.9.0 'Carbon' (LTS) Release
gibfahn Oct 31, 2017
40d8211
Working on v8.9.1
gibfahn Oct 31, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lib: setup IPC channel before console
Initializing IOCP on the same fd twice can fail on Windows.
Consequently, if the IPC channel uses fd 1 or 2 and the console is setup
first, writing to the IPC channel will fail.

PR-URL: #16562
Fixes: #16141
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
seishun authored and gibfahn committed Oct 31, 2017
commit 8c0c456c73a25605122676341ff3f751cbf74543
12 changes: 6 additions & 6 deletions lib/internal/bootstrap_node.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,6 @@
NativeModule.require('internal/process/next_tick').setup();
NativeModule.require('internal/process/stdio').setup();

const browserGlobals = !process._noBrowserGlobals;
if (browserGlobals) {
setupGlobalTimeouts();
setupGlobalConsole();
}

const perf = process.binding('performance');
const {
NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE,
Expand Down Expand Up @@ -70,6 +64,12 @@

_process.setupRawDebug();

const browserGlobals = !process._noBrowserGlobals;
if (browserGlobals) {
setupGlobalTimeouts();
setupGlobalConsole();
}

// Ensure setURLConstructor() is called before the native
// URL::ToObject() method is used.
NativeModule.require('internal/url');
Expand Down
18 changes: 18 additions & 0 deletions test/parallel/test-child-process-stdout-ipc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
'use strict';
const common = require('../common');
const assert = require('assert');

const spawn = require('child_process').spawn;

if (process.argv[2] === 'child') {
process.send('hahah');
return;
}

const proc = spawn(process.execPath, [__filename, 'child'], {
stdio: ['inherit', 'ipc', 'inherit']
});

proc.on('exit', common.mustCall(function(code) {
assert.strictEqual(code, 0);
}));