Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add missing comma in sources list #16613

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Oct 30, 2017

This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:

Warning: Missing input files:
src\tracing\trace_event.hsrc\util.h
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 30, 2017
@danbev
Copy link
Contributor Author

danbev commented Oct 30, 2017

@gireeshpunathil
Copy link
Member

I wonder how it was building / working so far with this issue!

@danbev
Copy link
Contributor Author

danbev commented Nov 1, 2017

Triggering another CI to double check Windows failure: https://ci.nodejs.org/job/node-test-pull-request/11125/

@danbev danbev force-pushed the build-missing-comma-sources branch from 4688584 to 3ca202f Compare November 1, 2017 06:19
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:

Warning: Missing input files:
src\tracing\trace_event.hsrc\util.h
@danbev
Copy link
Contributor Author

danbev commented Nov 1, 2017

@danbev
Copy link
Contributor Author

danbev commented Nov 1, 2017

test/arm-fanned failure looks unrelated

console output:

warning: failed to remove out/
Removing out/
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Did not find any matching files. Setting build result to FAILURE.
Checking ^not ok
Jenkins Text Finder: File set '*.tap' is empty
Notifying upstream projects of job completion
Finished: FAILURE
test/windows-fanned failure looks unrelated

console output:

Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
[node-test-binary-windows] $ cmd /c call C:\Users\ADMINI~1\AppData\Local\Temp\1\jenkins4777955810906737101.bat

c:\workspace\node-test-binary-windows>echo off 
Wed 11/01/2017  4:03:40.35

c:\workspace\node-test-binary-windows>tasklist   | grep node   || true

c:\workspace\node-test-binary-windows>exit 0 
[node-test-binary-windows] $ cmd /c call C:\Users\ADMINI~1\AppData\Local\Temp\1\jenkins2702603836202563709.bat

c:\workspace\node-test-binary-windows>TASKKILL /F /IM node.exe /T   || TRUE
ERROR: The process "node.exe" not found.

c:\workspace\node-test-binary-windows>TASKKILL /F /IM cctest.exe /T   || TRUE
ERROR: The process "cctest.exe" not found.

c:\workspace\node-test-binary-windows>TASKKILL /F /IM run-tests.exe /T   || TRUE
ERROR: The process "run-tests.exe" not found.

c:\workspace\node-test-binary-windows>TASKKILL /F /IM yes.exe /T   || TRUE
ERROR: The process "yes.exe" not found.

c:\workspace\node-test-binary-windows>git checkout -f refs/remotes/jenkins_tmp/jenkins-node-test-commit-windows-fanned-13053-binary-windows/win-vs2013 
error: pathspec 'refs/remotes/jenkins_tmp/jenkins-node-test-commit-windows-fanned-13053-binary-windows/win-vs2013' did not match any file(s) known to git.

c:\workspace\node-test-binary-windows>if 1 NEQ 0 exit /b 1 
Build step 'Execute Windows batch command' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Did not find any matching files. Setting build result to FAILURE.
Checking ^not ok
Jenkins Text Finder: File set '*.tap' is empty
Notifying upstream projects of job completion
Finished: FAILURE

@danbev
Copy link
Contributor Author

danbev commented Nov 1, 2017

Landed in 18df171

@danbev danbev closed this Nov 1, 2017
danbev added a commit that referenced this pull request Nov 1, 2017
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:

Warning: Missing input files:
src\tracing\trace_event.hsrc\util.h

PR-URL: #16613
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@danbev danbev deleted the build-missing-comma-sources branch November 1, 2017 08:33
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:

Warning: Missing input files:
src\tracing\trace_event.hsrc\util.h

PR-URL: nodejs/node#16613
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:

Warning: Missing input files:
src\tracing\trace_event.hsrc\util.h

PR-URL: nodejs#16613
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@cjihrig cjihrig mentioned this pull request Nov 6, 2017
@refack
Copy link
Contributor

refack commented Nov 10, 2017

I wonder how it was building / working so far with this issue!

Since these are .h files they are only used for change tracking, they are not actually compiled.
But this might explain why MSBuild is sometimes too eager to rebuild - because one of the files it's tracking will never exist.

gibfahn pushed a commit that referenced this pull request Nov 14, 2017
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:

Warning: Missing input files:
src\tracing\trace_event.hsrc\util.h

PR-URL: #16613
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:

Warning: Missing input files:
src\tracing\trace_event.hsrc\util.h

PR-URL: nodejs/node#16613
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.