src: use internal/errors for startSigintWatchdog #16546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasnell
added
the
semver-major
|
Ping @nodejs/tsc |
joyeecheung
reviewed
Oct 27, 2017
doc/api/errors.md
Outdated
| <a id="ERR_REPL_STARTSIGINTWATCHDOG_FAILED"></a> | ||
| ### ERR_REPL_STARTSIGINTWATCHDOG_FAILED | ||
|
|
||
| The `SigintWatchdog` is an internal utility used by the `repl` module to |
There was a problem hiding this comment.
Is it too much detail? AFAICT this is triggered by a failed pthread_create, may be we don't have to mention the watch dog thing, simply saying that node is unable to monitor SIGINT is enough? (ERR_REPL_SIGINTWATCH_FAILED)
There was a problem hiding this comment.
EDIT: paste error, s/sigmask/pthread_create/
There was a problem hiding this comment.
I agree, both the error code & the docs on it do have too much detail – ERR_CANNOT_WATCH_SIGINT or so should be fine.
lpinca
approved these changes
Oct 27, 2017
Move the throw out of c++ and into js using internal/errors
jasnell
force-pushed
the
migrate-util-sigintwatchdog
branch
from
f99ee60
to
0d89d4d
Compare
|
ping @joyeecheung and @addaleax |
joyeecheung
approved these changes
Oct 30, 2017
jasnell
added a commit
that referenced
this pull request
Nov 2, 2017
Move the throw out of c++ and into js using internal/errors PR-URL: #16546 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in 67c8511 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the throw out of c++ and into js using internal/errors
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src, repl