Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: allow port 80 in http2.connect #16337

Closed
wants to merge 1 commit into from
Closed

http2: allow port 80 in http2.connect #16337

wants to merge 1 commit into from

Commits on Oct 23, 2017

  1. http2: allow port 80 in http2.connect 

    Due to how WHATWG-URL parser works, port numbers are omitted if
they are the default port for a scheme. This meant that
http2.connect could not accept connections on port 80 with http
scheme. Fix this bug by detecting http: scheme and setting port
to 80.

Fixes: nodejs#14304
    @apapirovski
    apapirovski committed Oct 23, 2017
    Configuration menu
    Copy the full SHA
    e756215 View commit details
    Browse the repository at this point in the history