test: fix regression in test-require-resolver.js #16192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Oct 13, 2017
|
+1 for fast tracking this |
richardlau
approved these changes
Oct 14, 2017
|
Landed in 91a465c. |
tniessen
added a commit
that referenced
this pull request
Oct 14, 2017
PR-URL: #16192 Refs: #15984 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
PR-URL: nodejs/node#16192 Refs: nodejs/node#15984 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #16192 Refs: #15984 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect this is the reason for the regression reported here.
Refs: #15984
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test