src: remove unused includes from node_wrap.h #16179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
gireeshpunathil
approved these changes
Oct 13, 2017
|
Minor nit: 'includeds' should probably be 'includes' in the commit message |
I cannot find any usages of these includes and think they can be removed.
Indeed, I'll fix that. Thanks! |
danbev
force-pushed
the
unused-includes-node_wrap.h
branch
from
f136a1d
to
02f8cda
Compare
danbev
changed the title
|
CI did not run any subtasks. (There's a problem that @nodejs/build may or may not have fixed by now.) It will need to be re-run. |
cjihrig
approved these changes
Oct 15, 2017
jasnell
approved these changes
Oct 15, 2017
jasnell
pushed a commit
that referenced
this pull request
Oct 15, 2017
I cannot find any usages of these includes and think they can be removed. PR-URL: #16179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 75f154b |
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
I cannot find any usages of these includes and think they can be removed. PR-URL: #16179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 18, 2017
I cannot find any usages of these includes and think they can be removed. PR-URL: nodejs/node#16179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Should this be backported to |
danbev
added a commit
to danbev/node
that referenced
this pull request
Nov 17, 2017
I cannot find any usages of these includes and think they can be removed. PR-URL: nodejs#16179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
I cannot find any usages of these includes and think they can be removed. Backport-PR-URL: #17092 PR-URL: #16179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
I cannot find any usages of these includes and think they can be removed. Backport-PR-URL: #17092 PR-URL: #16179 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot find any usages of these includes and think they can be
removed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src