Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced fixturesDir with common.fixtures module #16051

Closed
wants to merge 2 commits into from

Conversation

rachelnicole
Copy link
Contributor

@rachelnicole rachelnicole commented Oct 6, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@joyeecheung
Copy link
Member

@joyeecheung
Copy link
Member

joyeecheung commented Oct 6, 2017

Ah, pressed the approval button too early, the commit message is missing subsytem labels. I guess whoever lands this can change the commit message to something like test: replace fixturesDir with common.fixtures instead.

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@mscdex mscdex added the module Issues and PRs related to the module subsystem. label Oct 6, 2017
@refack
Copy link
Contributor

refack commented Oct 6, 2017

Welcome to the dark side @rachelnicole 😉. Hope C&L was fun.

Besides the commit message there's also a list error:

not ok 10 - /usr/home/iojs/build/workspace/node-test-linter/test/parallel/test-internal-modules.js
  ---
  message: '''path'' is assigned a value but never used.'
  severity: error
  data:
    line: 4
    column: 7
    ruleId: no-unused-vars
  ...

This can also be fixed by whomever lands this.
Otherwise I believe the CI is clean.

@refack refack self-assigned this Oct 6, 2017
@rachelnicole
Copy link
Contributor Author

@refack I can totally remove the reference to path and push it up if that's easier!

@refack
Copy link
Contributor

refack commented Oct 6, 2017

@refack I can totally remove the reference to path and push it up if that's easier!

Follow up by the OP is always appreciated, thank you. 🥇

@refack
Copy link
Contributor

refack commented Oct 6, 2017

P.S. you can also locally run make jslint or even node tools/eslint/bin/eslint.js --rulesdir=tools/eslint-rules test/parallel/test-internal-modules.js to make sure you didn't miss any of the other linting rules.

@rachelnicole
Copy link
Contributor Author

@refack i'm on windows and neither of those things worked. D: i might be missing some stuff

@refack
Copy link
Contributor

refack commented Oct 6, 2017

Ohh yeah us Windows devs need to do things a little different (vcbuild nobuild noprojgen lint).
But anyway a new CI linter came back clean - https://ci.nodejs.org/job/node-test-linter/12268.
So this is all set to go 💯 (just need to tweak the commit message while landing).

@joyeecheung
Copy link
Member

Last CI before landing: https://ci.nodejs.org/job/node-test-pull-request/10476/

@refack refack removed their assignment Oct 7, 2017
@joyeecheung
Copy link
Member

Landed in bdf711d, thanks for the contribution!

joyeecheung pushed a commit that referenced this pull request Oct 8, 2017
PR-URL: #16051
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@Trott Trott closed this Oct 8, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
PR-URL: #16051
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
PR-URL: nodejs/node#16051
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
PR-URL: #16051
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
PR-URL: #16051
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
PR-URL: #16051
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants