Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change crypto decipheriv assertion messages #16007

Closed
wants to merge 1 commit into from
Closed

test: change crypto decipheriv assertion messages #16007

wants to merge 1 commit into from

Conversation

stropitek
Copy link
Contributor

@stropitek stropitek commented Oct 6, 2017 •
edited
Loading

Includes problematic key and iv values into the assertion message

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@stropitek
test: change crypto decipheriv assertion messages
798d6c5 
Includes problematic key and iv values into the assertion message
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10677/

@Trott
Copy link
Member

Trott commented Oct 13, 2017

CI will need to be re-run for this. It's not running any subtasks.

@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10705/

lpinca
lpinca approved these changes Oct 14, 2017
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I wonder if it's better to completely remove the message argument. Anyway it can be done in another PR.

@joyeecheung
Copy link
Member

Landed in 2b0145d, thank you for the contribution!

joyeecheung pushed a commit that referenced this pull request Oct 14, 2017
@stropitek @joyeecheung
test: change crypto decipheriv assertion messages
2b0145d 
Includes problematic key and iv values into the assertion message

PR-URL: #16007
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@stropitek @addaleax
test: change crypto decipheriv assertion messages
9fedb64 
Includes problematic key and iv values into the assertion message

PR-URL: nodejs/node#16007
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@stropitek @targos
test: change crypto decipheriv assertion messages
f753aed 
Includes problematic key and iv values into the assertion message

PR-URL: #16007
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@stropitek @MylesBorins
test: change crypto decipheriv assertion messages
3b8dae4 
Includes problematic key and iv values into the assertion message

PR-URL: #16007
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@stropitek @MylesBorins
test: change crypto decipheriv assertion messages
b43f366 
Includes problematic key and iv values into the assertion message

PR-URL: #16007
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@stropitek @MylesBorins
test: change crypto decipheriv assertion messages
d591750 
Includes problematic key and iv values into the assertion message

PR-URL: #16007
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@hiroppy hiroppy hiroppy approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@stropitek @joyeecheung @Trott @jasnell @lpinca @targos @hiroppy @mscdex @MylesBorins @nodejs-github-bot