async_hooks: replace string concatenation with template literals #15968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
radelmann
force-pushed
the
init-hooks.js
branch
from
f1fbc91
to
3f5a3cb
Compare
Trott
added
the
code-and-learn
radelmann
force-pushed
the
init-hooks.js
branch
2 times, most recently
from
8bf9e77
to
81e5a13
Compare
BridgeAR
reviewed
Oct 7, 2017
test/async-hooks/init-hooks.js
Outdated
| '\nExpected "init" to be called at most once'); | ||
| v(`Activity inited twice | ||
| ${tempActivityString} | ||
| Expected "init" to be called at most once`); |
There was a problem hiding this comment.
Please prevent use multiline template strings. This adds lots and lots of whitespace infront of line 2 + 3. Instead, keep the + for each new line and use \n if necessary..
There was a problem hiding this comment.
@BridgeAR Thanks for the feedback. Removed the multiline template strings and went back to using + and \n.
updated test/async-hooks/init-hooks.js
radelmann
force-pushed
the
init-hooks.js
branch
from
81e5a13
to
d818b46
Compare
gibfahn
approved these changes
Oct 9, 2017
jasnell
approved these changes
Oct 12, 2017
jasnell
pushed a commit
that referenced
this pull request
Oct 12, 2017
updated test/async-hooks/init-hooks.js PR-URL: #15968 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 3ea3c08 |
charmander
reviewed
Oct 12, 2017
| @@ -65,49 +65,52 @@ class ActivityCollector { | |||
| } | |||
|
|
|||
| const violations = []; | |||
| let tempActivityString; | |||
There was a problem hiding this comment.
Is there a reason this is scoped outside the loop?
| '\nExpected "destroy" to be called at most once'); | ||
| } | ||
| if (a.before && a.after) { | ||
| if (a.before.length < a.after.length) { | ||
| v('Activity called "after" without calling "before"\n' + | ||
| activityString(a) + | ||
| `${tempActivityString}` + |
There was a problem hiding this comment.
Equivalent to tempActivityString?
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
updated test/async-hooks/init-hooks.js PR-URL: nodejs/node#15968 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
updated test/async-hooks/init-hooks.js PR-URL: #15968 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
updated test/async-hooks/init-hooks.js PR-URL: #15968 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated test/async-hooks/init-hooks.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, async_hooks