Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: incremental improvements #15693

Closed
wants to merge 4 commits into from
Closed

http2: incremental improvements #15693

wants to merge 4 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 29, 2017

Several different bits in here. All incremental improvements.

The last commit in the bunch (making sending to the socket more efficient) should be reviewed carefully to make sure it's not introducing any sneaky bugs.

@nodejs/http2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Sep 29, 2017
@mscdex mscdex added the http2 Issues or PRs related to the http2 subsystem. label Sep 29, 2017
mcollina
mcollina approved these changes Oct 2, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member Author

jasnell commented Oct 2, 2017

@apapirovski ... can I ask you to take a look over this and test it against your express test suite?

@jasnell
Copy link
Member Author

jasnell commented Oct 2, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10382/

apapirovski
apapirovski approved these changes Oct 2, 2017
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also no change in express & on-finished test results when applied over top of my compatibility changes.

jasnell added a commit that referenced this pull request Oct 2, 2017
@jasnell
http2: simplify TypeName
8fa0247 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
jasnell added a commit that referenced this pull request Oct 2, 2017
@jasnell
http2: refactor method arguments to avoid bools
8f4db31 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
jasnell added a commit that referenced this pull request Oct 2, 2017
@jasnell
http2: eliminate dead code
8691d8b 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
jasnell added a commit that referenced this pull request Oct 2, 2017
@jasnell
http2: making sending to the socket more efficient
7092a6c 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Oct 2, 2017

Landed in 8fa0247, 8f4bd31, 8691d8b and 7092a6c

@jasnell jasnell closed this Oct 2, 2017
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@jasnell @MylesBorins
http2: simplify TypeName
f10e2f5 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@jasnell @MylesBorins
http2: refactor method arguments to avoid bools
470ef86 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@jasnell @MylesBorins
http2: eliminate dead code
7611ed5 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@jasnell @MylesBorins
http2: making sending to the socket more efficient
93f3d25 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@jasnell @MylesBorins
http2: simplify TypeName
18dbcf2 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@jasnell @MylesBorins
http2: refactor method arguments to avoid bools
420139f 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@jasnell @MylesBorins
http2: eliminate dead code
e5feb7d 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@jasnell @MylesBorins
http2: making sending to the socket more efficient
a8020bf 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
@jasnell @addaleax
http2: simplify TypeName
6095084 
PR-URL: nodejs/node#15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
@jasnell @addaleax
http2: refactor method arguments to avoid bools
df1dc28 
PR-URL: nodejs/node#15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
@jasnell @addaleax
http2: making sending to the socket more efficient
d483ca3 
PR-URL: nodejs/node#15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
@jasnell @addaleax
http2: eliminate dead code
be1b184 
PR-URL: nodejs/node#15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@jasnell @MylesBorins
http2: simplify TypeName
86ee05d 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@jasnell @MylesBorins
http2: refactor method arguments to avoid bools
078ee27 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@jasnell @MylesBorins
http2: eliminate dead code
68cd233 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@jasnell @MylesBorins
http2: making sending to the socket more efficient
86dfcc6 
PR-URL: #15693
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @apapirovski @mcollina @mscdex @MylesBorins @nodejs-github-bot