Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix link in the test/README.md #15642

Closed
wants to merge 1 commit into from
Closed

Conversation

rmisev
Copy link
Contributor

@rmisev rmisev commented Sep 27, 2017

It seems the link must point to [Step 6: Test](#step-6-test):

node/CONTRIBUTING.md

Lines 33 to 35 in 93985ef

* [Step 5: Rebase](#step-5-rebase)
* [Step 6: Test](#step-6-test)
* [Step 7: Push](#step-7-push)

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 27, 2017
@mscdex mscdex added the doc Issues and PRs related to the documentations. label Sep 27, 2017
jasnell pushed a commit that referenced this pull request Sep 29, 2017
PR-URL: #15642
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Sep 29, 2017

landed in 9807744

@jasnell jasnell closed this Sep 29, 2017
@rmisev rmisev deleted the doc-fix-link branch September 29, 2017 18:04
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
PR-URL: #15642
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
PR-URL: nodejs/node#15642
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
PR-URL: #15642
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
PR-URL: #15642
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
PR-URL: #15642
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants