[v8.x backport] assert: fix boxed primitives in deepStrictEqual

[BridgeAR]

Ref #15050

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

assert

[jasnell]

@BridgeAR, this appears to be causing a failure with one of the napi_addon tests:

james@ubuntu:~/node/main$ ./node test/addons-napi/test_conversions/test.js
assert.js:41
  throw new errors.AssertionError({
  ^

AssertionError [ERR_ASSERTION]: [Number: NaN] deepStrictEqual [Number: NaN]
    at Object.<anonymous> (/home/james/node/main/test/addons-napi/test_conversions/test.js:118:8)
    at Module._compile (module.js:624:30)
    at Object.Module._extensions..js (module.js:635:10)
    at Module.load (module.js:545:32)
    at tryModuleLoad (module.js:508:12)
    at Function.Module._load (module.js:500:3)
    at Function.Module.runMain (module.js:665:10)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:607:3
james@ubuntu:~/node/main$

[jasnell]

Should that line simply be removed?

[BridgeAR]

@jasnell I already removed that test yesterday?

[jasnell]

I just applied this PR today against v8.x-staging and it failed. I see that you removed one of the NaN checks in that file so I'm removing this second one and checking the tests again.

[jasnell]

That worked. Landed in v8.x-staging. Thank you!

[BridgeAR]

@jasnell right, I missed that there were two in there and I did not run the tests again. Thanks for fixing that!