Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: increase coverage by removing dead code #15100

Merged
merged 1 commit into from
Sep 1, 2017
Merged

buffer: increase coverage by removing dead code #15100

merged 1 commit into from
Sep 1, 2017

Commits on Sep 1, 2017

  1. buffer: increase coverage by removing dead code 

    buffer.js:L196 `if (value == null)` guarantees `obj != null`
so L406+L418 are unnecessary.

PR-URL: nodejs#15100
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @decareano @refack
    decareano authored and refack committed Sep 1, 2017
    Configuration menu
    Copy the full SHA
    08984b2 View commit details
    Browse the repository at this point in the history