Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix dtrace-enabled build on os x #150

Merged
merged 1 commit into from
Dec 11, 2014

Conversation

bnoordhuis
Copy link
Member

Commit 691d55f introduces a regression on OS X when dtrace is enabled
(the default.) This commit rectifies that by removing the erroneous
platform check.

Fixes the following build error:

CXX(target) /Users/bnoordhuis/src/iojs/out/Release/obj.target/node/src/node_dtrace.o
../src/node_dtrace.cc:27:10: fatal error: 'node_provider.h' file not found

R=@bajtos, /cc @evantorrie

@bajtos
Copy link
Contributor

bajtos commented Dec 11, 2014

The patch fixes the problem for me. :shipit:

Commit 691d55f introduces a regression on OS X when dtrace is enabled
(the default.)  This commit rectifies that by removing the erroneous
platform check.

Fixes the following build error:

    CXX(target) /Users/bnoordhuis/src/iojs/out/Release/obj.target/node/src/node_dtrace.o
    ../src/node_dtrace.cc:27:10: fatal error: 'node_provider.h' file not found

PR-URL: nodejs#150
Reviewed-By: Miroslav Bajtoš <[email protected]>
@bnoordhuis bnoordhuis merged commit 0fbe528 into nodejs:v0.12 Dec 11, 2014
@bnoordhuis bnoordhuis deleted the fix-osx-dtrace-build branch December 11, 2014 17:23
@rmg
Copy link
Contributor

rmg commented Dec 11, 2014

I was just about to report this myself, good timing!

boingoing added a commit to boingoing/node that referenced this pull request Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants