src: fix build on certain platforms #14996
Conversation
nodejs-github-bot
added
the
c++
|
+1 on fast tracking :-) ... assuming we can get CI to stay up long enough to do an actual test. |
The `double` fields in `performance_state` could previously have been aligned at 4-byte instead of 8-byte boundaries, which would have made creating an Float64Array them as a array buffer view for an ArrayBuffer extending over the entire struct an invalid operation. Ref: 67269fd
addaleax
changed the title
|
Updated the PR & did the same thing for HTTP2 where this worked out by accident because there was an even number of |
|
Yep, it was a bug waiting to happen in the http2 code too. Those fields are quite likely to change. Thank you for including those. |
|
CI: https://ci.nodejs.org/job/node-test-commit/11990/ Already got some buildbot failures so we might be trying again soon |
|
The other run is almost complete, starting a new one see if we can get past the buildbot failures https://ci.nodejs.org/job/node-test-pull-request/9814/ |
|
+1 for fast tracking.
BTW: You can stop the job then hit "rebuild", that will only retry the incomplete/failed subjobs. |
|
This is looking good so far. I did push a commit in to comment out a flaky precision comparison in one of the tests (it's the first time I've seen it.. and I'll revisit it in a separate PR.). Assuming this run is clear I'll land shortly. |
|
Yes i know we can "rebuild" on the CI. Given the build bot failures I wanted to do a complete fresh rerun. |
The `double` fields in `performance_state` could previously have been aligned at 4-byte instead of 8-byte boundaries, which would have made creating an Float64Array them as a array buffer view for an ArrayBuffer extending over the entire struct an invalid operation. Ref: 67269fd Comments out related flaky failure PR-URL: #14996 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
|
Landed in 86c4655 |
The `double` fields in `performance_state` could previously have been aligned at 4-byte instead of 8-byte boundaries, which would have made creating an Float64Array them as a array buffer view for an ArrayBuffer extending over the entire struct an invalid operation. Ref: 67269fd Comments out related flaky failure PR-URL: nodejs/node#14996 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
The `double` fields in `performance_state` could previously have been aligned at 4-byte instead of 8-byte boundaries, which would have made creating an Float64Array them as a array buffer view for an ArrayBuffer extending over the entire struct an invalid operation. Ref: 67269fd Comments out related flaky failure PR-URL: nodejs/node#14996 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
The `double` fields in `performance_state` could previously have been aligned at 4-byte instead of 8-byte boundaries, which would have made creating an Float64Array them as a array buffer view for an ArrayBuffer extending over the entire struct an invalid operation. Ref: 67269fd Comments out related flaky failure PR-URL: #14996 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
The `double` fields in `performance_state` could previously have been aligned at 4-byte instead of 8-byte boundaries, which would have made creating an Float64Array them as a array buffer view for an ArrayBuffer extending over the entire struct an invalid operation. Ref: 67269fd Comments out related flaky failure PR-URL: #14996 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
The `double` fields in `performance_state` could previously have been aligned at 4-byte instead of 8-byte boundaries, which would have made creating an Float64Array them as a array buffer view for an ArrayBuffer extending over the entire struct an invalid operation. Ref: 67269fd Comments out related flaky failure PR-URL: #14996 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
The
doublefields inperformance_statecould previously havebeen aligned at 4-byte instead of 8-byte boundaries, which would
have made creating an Float64Array them as a array buffer view
for an ArrayBuffer extending over the entire struct an invalid
operation.
Ref: 67269fd
Would suggest fast-tracking to unbreak CI, assuming this works.
/cc @jasnell