Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make timers-blocking-callback more reliable #14831

Closed
wants to merge 5 commits into from
Closed

test: make timers-blocking-callback more reliable #14831

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
83208ab
test: make timers-blocking-callback more reliable
Trott Aug 14, 2017
c208131
squash: message nit
Trott Aug 18, 2017
fce2712
squash: update comment
Trott Aug 18, 2017
ec83819
squash: > to >=
Trott Aug 18, 2017
0f352fd
squash: do not timer-bomb ourselves
Trott Aug 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: update comment
  • Loading branch information
@Trott
Trott committed Aug 18, 2017
commit fce27122560f0cd7bef6d7360c587a0698c12148
15 changes: 8 additions & 7 deletions test/sequential/test-timers-blocking-callback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,14 @@ let nbBlockingCallbackCalls;
let latestDelay;
let timeCallbackScheduled;

// These tests are somewhat probablistic so they may fail even when the bug is
// not present. However, they fail 100% of the time when the bug *is* present,
// so to increase reliability, allow for a small number of retries. (Keep it
// small because as currently written, one failure could result in multiple
// simultaneous retries of the test. Don't want to timer-bomb ourselves.
// Observed failures are infrequent anyway, so only a small number of retries
// is hopefully more than sufficient.)
// These tests are timing dependent so they may fail even when the bug is
// not present (if the host is sufficiently busy that the timers are delayed
// significantly). However, they fail 100% of the time when the bug *is*
// present, so to increase reliability, allow for a small number of retries.
// (Keep it small because as currently written, one failure could result in
// multiple simultaneous retries of the test. Don't want to timer-bomb
// ourselves. Observed failures are infrequent anyway, so only a small number of
// retries is hopefully more than sufficient.)
let retries = 2;

function initTest() {
Expand Down