Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: fix inspector v8 test #14827

Merged
merged 0 commits into from
Aug 16, 2017
Merged

deps: fix inspector v8 test #14827

merged 0 commits into from
Aug 16, 2017

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Aug 14, 2017

This fixes the inspector tests failing after the cherry-pick.

Fixes: #14824

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

deps: added a missing function.

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Aug 14, 2017
@eugeneo
Copy link
Contributor Author

eugeneo commented Aug 14, 2017

CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/852/

Note that this test is not exercised in regular Node CI.

addaleax
addaleax approved these changes Aug 14, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; can you link to the original patch that this is taken from in the commit message?

@eugeneo
Copy link
Contributor Author

eugeneo commented Aug 14, 2017

LGTM; can you link to the original patch that this is taken from in the commit message?

Done (in the commit, not the PR description)

mhdawson
mhdawson approved these changes Aug 16, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eugeneo eugeneo closed this Aug 16, 2017
@eugeneo eugeneo deleted the test-v8 branch August 16, 2017 23:29
@eugeneo eugeneo merged commit cd9f81d into nodejs:master Aug 16, 2017
@eugeneo
Copy link
Contributor Author

eugeneo commented Aug 16, 2017

Landed as cd9f81d

MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@MylesBorins
deps: fix inspector v8 test
7995897 
This fixes the inspector tests failing after the cherry-pick.

V8 commit: https://chromium.googlesource.com/v8/v8/+/f19b889be801bdebc04c49090e37c787f7ba8805
PR-URL: #14827
Fixes: #14824
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@MylesBorins
deps: fix inspector v8 test
1a2f749 
This fixes the inspector tests failing after the cherry-pick.

V8 commit: https://chromium.googlesource.com/v8/v8/+/f19b889be801bdebc04c49090e37c787f7ba8805
PR-URL: #14827
Fixes: #14824
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V8 tests failing
7 participants
@eugeneo @jasnell @addaleax @targos @mhdawson @MylesBorins @nodejs-github-bot