doc: add missing changes: metadata for recent PRs
#14810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
approved these changes
Aug 13, 2017
addaleax
added a commit
that referenced
this pull request
Aug 13, 2017
Ref: #14636 PR-URL: #14810 Reviewed-By: Jeremiah Senkpiel <[email protected]>
addaleax
added a commit
that referenced
this pull request
Aug 13, 2017
Ref: #14558 PR-URL: #14810 Reviewed-By: Jeremiah Senkpiel <[email protected]>
addaleax
added a commit
that referenced
this pull request
Aug 13, 2017
Ref: #14636 PR-URL: #14810 Reviewed-By: Jeremiah Senkpiel <[email protected]>
addaleax
added a commit
that referenced
this pull request
Aug 13, 2017
Ref: #14558 PR-URL: #14810 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #14636
Ref: #14558
In separate commits because it’s not clear whether both features either get backported to LTS or not backported, and if they are, whether that happens at the same time.
@nodejs/collaborators As a small reminder, try to watch out for this when reviewing API changes :) Also, would be helpful if this could be fast-tracked.