Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run test-hash-seed at the end of test-v8 #14219

Closed
wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jul 13, 2017

The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)

I'm open to a better solution but I don't think test-hash-seed shoud be run here, even if we make it sequential (V8 has to be built twice).

@ofrobots @nodejs/v8

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jul 13, 2017
refack
refack previously approved these changes Jul 13, 2017
@refack
Copy link
Contributor

refack commented Jul 13, 2017

Sounds right to me. IMHO test-hash-seed is a node test (and is run under pummel) not a V8 test...

@ofrobots
Copy link
Contributor

The original motivation was to make sure this gets run whenever we update V8 (i.e. the time we usually run test-v8 in the CI). IMO, test-hash-seed is too slow to be run in the normal CI. Let me see if there might be another way to do this..

@ofrobots
Copy link
Contributor

Perhaps something like:

--- a/Makefile
+++ b/Makefile
@@ -433,13 +433,15 @@ test-async-hooks:


 ifneq ("","$(wildcard deps/v8/tools/run-tests.py)")
-test-v8: v8 test-hash-seed
+test-v8: v8
 #      note: performs full test unless QUICKCHECK is specified
        deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
         --mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) $(QUICKCHECK_ARG) \
         --no-presubmit \
         --shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
         $(TAP_V8)
+        @echo Testing hash seed
+        $(MAKE) test-hash-seed

The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: nodejs#14004 (comment)
@targos
Copy link
Member Author

targos commented Jul 14, 2017

@targos targos changed the title build: do not run test-hash-seed with test-v8 build: run test-hash-seed at the end of test-v8 Jul 14, 2017
@targos
Copy link
Member Author

targos commented Jul 14, 2017

CI is green. Can we fast-track this fix to unbreak it?

@targos
Copy link
Member Author

targos commented Jul 14, 2017

BTW I understood why test-hash-seed was there and it makes sense. I was reluctant because of the double V8 build but the job took only 30 minutes to run so that's fine.

@refack
Copy link
Contributor

refack commented Jul 14, 2017

$(MAKE) test-hash-seed

Just to be sure, spawning a sub-make propagates the exit code?

@targos
Copy link
Member Author

targos commented Jul 14, 2017

@refack With this:

test-a: test-b
        echo "test-a"
        $(MAKE) test-c

test-b:
        echo "test-b"

test-c:
        node -e "process.exit(1)"
$ make test-a
echo "test-b"
test-b
echo "test-a"
test-a
make test-c
node -e "process.exit(1)"
make[1]: *** [Makefile:442: test-c] Error 1
make: *** [Makefile:436: test-a] Error 2

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternative is to make a new nightly job that just runs the hashseed test on its own. That would remove the overhead for those doing individual regression runs instead of the nightlies. We then might want to create better nightly job which runs both the hashseed and v8 test jobs.

In any case I'm +1 to landing this now to get the test back to green and the improve.

@mhdawson
Copy link
Member

I also think we should expedite landing this since the jobs are completely broken as they currently are.

@addaleax
Copy link
Member

addaleax commented Jul 14, 2017

Landed in 016d81c

@addaleax addaleax closed this Jul 14, 2017
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 14, 2017
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: nodejs#14004 (comment)
PR-URL: nodejs#14219
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@addaleax addaleax mentioned this pull request Jul 18, 2017
addaleax pushed a commit that referenced this pull request Jul 18, 2017
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)
PR-URL: #14219
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos deleted the makefile-test-hash-seed branch July 18, 2017 19:25
MylesBorins pushed a commit that referenced this pull request Jul 18, 2017
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)
PR-URL: #14219
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)
PR-URL: #14219
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 21, 2017
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)
PR-URL: #14219
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Oct 2, 2017
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: nodejs#14004 (comment)
PR-URL: nodejs#14219
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 18, 2017
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)
Backport-PR-URL: #15562
PR-URL: #14219
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
The v8 and test-hash-seed targets cannot be run in parallel because they
need different copies of the deps/v8 directory.

Ref: #14004 (comment)
Backport-PR-URL: #15562
PR-URL: #14219
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants