test: refactor test-fs-watch-stop-async #13661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use common.mustNotCall() to confirm callback is not invoked * blank line after common module per test writing guide
Trott
added
fs
refack
approved these changes
Jun 13, 2017
richardlau
approved these changes
Jun 13, 2017
cjihrig
approved these changes
Jun 13, 2017
jasnell
approved these changes
Jun 13, 2017
lpinca
approved these changes
Jun 14, 2017
|
Landed in f462ad1 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 15, 2017
* use common.mustNotCall() to confirm callback is not invoked * blank line after common module per test writing guide PR-URL: nodejs#13661 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jun 17, 2017
* use common.mustNotCall() to confirm callback is not invoked * blank line after common module per test writing guide PR-URL: #13661 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 21, 2017
* use common.mustNotCall() to confirm callback is not invoked * blank line after common module per test writing guide PR-URL: #13661 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test fs