Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add coverage for napi_property_descriptor #13510

Closed
wants to merge 2 commits into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Jun 6, 2017

We did not have test coverage for using a napi_value
pointing to a string or symbol for the name when
creating a property. Add that coverage.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows [commit guidelines]
Affected core subsystem(s)

test, n-api

We did not have test coverage for using a napi_value
pointing to a string or symbol for the name when
creating a property.  Add that coverage.
@nodejs-github-bot nodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Jun 6, 2017
@jasongin
Copy link
Member

jasongin commented Jun 6, 2017

Should we also have a test case that uses a symbol as a property name?

@mhdawson
Copy link
Member Author

mhdawson commented Jun 7, 2017

@jasongin added commit to add test for creating property with a symbol.

@mhdawson
Copy link
Member Author

mhdawson commented Jun 8, 2017

@refack
Copy link
Contributor

refack commented Jun 9, 2017

Killed one part of one run on windows (after 4 hours) https://ci.nodejs.org/job/node-test-binary-windows/9109/RUN_SUBSET=0,VS_VERSION=vs2015,label=win2012r2/

@mhdawson
Copy link
Member Author

mhdawson commented Jun 9, 2017

I had accidentally kicked off 2 CI runs, the the link to the one posted in this PR passed, so issue is likely not related to PR.

@mhdawson
Copy link
Member Author

mhdawson commented Jun 9, 2017

Failure looks infra related as it did not get to the point of running tests.

@mhdawson
Copy link
Member Author

mhdawson commented Jun 9, 2017

Landed as 01f4d9a

@mhdawson mhdawson closed this Jun 9, 2017
mhdawson added a commit that referenced this pull request Jun 9, 2017
We did not have test coverage for using a napi_value
pointing to a string or symbol for the name when
creating a property.  Add that coverage.

PR-URL: #13510
Reviewed-By: Jason Ginchereau <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 10, 2017
We did not have test coverage for using a napi_value
pointing to a string or symbol for the name when
creating a property.  Add that coverage.

PR-URL: #13510
Reviewed-By: Jason Ginchereau <[email protected]>
@addaleax addaleax mentioned this pull request Jun 10, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
@mhdawson mhdawson deleted the napi-cov11 branch June 28, 2017 19:23
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
We did not have test coverage for using a napi_value
pointing to a string or symbol for the name when
creating a property.  Add that coverage.

PR-URL: nodejs#13510
Reviewed-By: Jason Ginchereau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
We did not have test coverage for using a napi_value
pointing to a string or symbol for the name when
creating a property.  Add that coverage.

Backport-PR-URL: #19447
PR-URL: #13510
Reviewed-By: Jason Ginchereau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants