tools: be explicit about including key-id #13309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpg 2.1 no longer includes the key-id by default which breaks the release script. This makes sure we are explicit about it.
gibfahn
approved these changes
May 30, 2017
|
Confirmed that this gives the same output in 2.1 (and that it still works with 2.0). |
jasnell
approved these changes
May 30, 2017
cjihrig
approved these changes
May 30, 2017
jasnell
pushed a commit
that referenced
this pull request
Jun 1, 2017
gpg 2.1 no longer includes the key-id by default which breaks the release script. This makes sure we are explicit about it. PR-URL: #13309 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in b7d1438 |
jasnell
pushed a commit
that referenced
this pull request
Jun 5, 2017
gpg 2.1 no longer includes the key-id by default which breaks the release script. This makes sure we are explicit about it. PR-URL: #13309 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Closed
3 tasks
MylesBorins
added a commit
that referenced
this pull request
Jul 17, 2017
gpg 2.1 no longer includes the key-id by default which breaks the release script. This makes sure we are explicit about it. PR-URL: #13309 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
added a commit
that referenced
this pull request
Jul 17, 2017
gpg 2.1 no longer includes the key-id by default which breaks the release script. This makes sure we are explicit about it. PR-URL: #13309 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Closed
MylesBorins
added a commit
that referenced
this pull request
Oct 25, 2017
gpg 2.1 no longer includes the key-id by default which breaks the release script. This makes sure we are explicit about it. PR-URL: #13309 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gpg 2.1 no longer includes the key-id by default which breaks
the release script. This makes sure we are explicit about it.