Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove TODO about uv errno removal #12536

Closed
wants to merge 3 commits into from
Closed

src: remove TODO about uv errno removal #12536

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe0b8d9
src: remove uv errno
danbev Apr 20, 2017
8d40cdc
Revert "src: remove uv errno"
danbev Apr 20, 2017
c93e1ea
src: remove TODO about uv errno removal
danbev Apr 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: remove TODO about uv errno removal 
This commit removes a TODO regarding the removal of uv errno. errno
is currently used and cannot be removed so removing the comment to
avoid any confusion.
  • Loading branch information
@danbev
danbev committed Apr 20, 2017
commit c93e1ea4e4e23d2c278adc5cb91d34054fc9eae6
2 changes: 0 additions & 2 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,8 +940,6 @@ Local<Value> UVException(Isolate* isolate,

Local<Object> e = Exception::Error(js_msg)->ToObject(isolate);

// TODO(piscisaureus) errno should probably go; the user has no way of
// knowing which uv errno value maps to which error.
e->Set(env->errno_string(), Integer::New(isolate, errorno));
e->Set(env->code_string(), js_code);
e->Set(env->syscall_string(), js_syscall);
Expand Down