test: more robust check for location of node.exe
#12120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm compiling for windows & ubuntu on the same dir so I have |
|
Can you update the commit log to explain how it's more robust? It's not immediately evident from looking at the diff. |
|
@bnoordhuis updated. Also added explicit error. |
bnoordhuis
approved these changes
Mar 29, 2017
tools/test.py
Outdated
| name = os.path.abspath(name + '.exe') | ||
|
|
||
| if not exists(name): | ||
| raise ValueError("Could not find executable") |
There was a problem hiding this comment.
Can you include name in the message and use single quotes?
look for the actual produced `exe` not just the directory
jasnell
approved these changes
Mar 29, 2017
gibfahn
approved these changes
Mar 31, 2017
|
cc/ @nodejs/platform-windows |
seishun
approved these changes
Mar 31, 2017
jasnell
pushed a commit
that referenced
this pull request
Apr 4, 2017
look for the actual produced `exe` not just the directory PR-URL: #12120 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]>
|
Landed in 394b6ac |
|
Yeah broke the slump ;) |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
look for the actual produced `exe` not just the directory PR-URL: nodejs#12120 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 18, 2017
look for the actual produced `exe` not just the directory PR-URL: #12120 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
look for the actual produced `exe` not just the directory PR-URL: #12120 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
look for the actual produced `exe` not just the directory PR-URL: nodejs/node#12120 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
vcbuild test(Windows) passesAffected core subsystem(s)
windows, test