Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: add space between error name and code #12099

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 28, 2017

Error[CODE] becomes Error [CODE]

Depends on: #11220

/cc @Trott @evanlucas

(I'm not sure how to classify this on the semver scale since we have not actually used it yet)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

errors

`Error[CODE]` becomes `Error [CODE]`
@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Mar 28, 2017
@jasnell jasnell requested review from evanlucas and Trott March 28, 2017 19:43
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gibfahn
Copy link
Member

gibfahn commented Mar 28, 2017

(I'm not sure how to classify this on the semver scale since we have not actually used it yet)

seems like a semver-patch then.

Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is better. Thanks!

@addaleax addaleax added this to the 8.0.0 milestone Mar 31, 2017
@addaleax
Copy link
Member

jasnell added a commit that referenced this pull request Apr 3, 2017
`Error[CODE]` becomes `Error [CODE]`

PR-URL: #12099
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Apr 3, 2017

Landed in 7b4a72d

@jasnell jasnell closed this Apr 3, 2017
@jasnell jasnell mentioned this pull request Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants