Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: backport 8dde6ac from upstream V8 #12060

Closed
wants to merge 1 commit into from
Closed

deps: backport 8dde6ac from upstream V8 #12060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
deps: backport 8dde6ac from upstream V8 
Commit 9c9e2d7 changed the name of TypeFeedbackVector to
FeedbackVector but that commit did not update gdbinit. This applies the
changed to gdbinit from upstream V8.

Original commit message:

[gdbinit] Rename TypeFeedback* to Feedback*.

    BUG=

    Change-Id: I1e32fdcf9edda57f5de329c8b694620a5da4558b
    Reviewed-on: https://chromium-review.googlesource.com/442444
    Reviewed-by: Michael Stanton <[email protected]>
    Commit-Queue: Igor Sheludko <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#43185}
  • Loading branch information
@danbev
danbev committed Mar 27, 2017
commit b04fa5412f108d5a68bb6258637b07a09fbdb20c
2 changes: 1 addition & 1 deletion deps/v8/src/objects-printer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1684,7 +1684,7 @@ extern void _v8_internal_Print_Code(void* object) {

extern void _v8_internal_Print_FeedbackVector(void* object) {
if (reinterpret_cast<i::Object*>(object)->IsSmi()) {
printf("Not a type feedback vector\n");
printf("Not a feedback vector\n");
} else {
reinterpret_cast<i::FeedbackVector*>(object)->Print();
}
Expand Down
8 changes: 4 additions & 4 deletions deps/v8/tools/gdbinit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ Print a v8 Code object from an internal code address
Usage: jco pc
end

# Print TypeFeedbackVector
# Print FeedbackVector
define jfv
call _v8_internal_Print_TypeFeedbackVector((void*)($arg0))
call _v8_internal_Print_FeedbackVector((void*)($arg0))
end
document jfv
Print a v8 TypeFeedbackVector object
Usage: jtv tagged_ptr
Print a v8 FeedbackVector object
Usage: jfv tagged_ptr
end

# Print DescriptorArray.
Expand Down