Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit the benchmark guide #12041

Closed
wants to merge 2 commits into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 25, 2017

These are minor typographical and style improvements to the guide for
writing and running benchmarks.

Checklist
Affected core subsystem(s)

doc benchmark

These are minor typographical and style improvements to the guide for
writing and running benchmarks.
@Trott Trott added benchmark Issues and PRs related to the benchmark subsystem. doc Issues and PRs related to the documentations. labels Mar 25, 2017
Copy link
Contributor

@seishun seishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit.

can specify which benchmarker should be used. You can force a specific
benchmarker to be used by providing it as an argument, e. g.:
By default, `wrk` will be used as the benchmarker. If it is not available,
`autocannon` will be used in its place. When creating a HTTP benchmark, you can
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/a /an /?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my preference too. I'll update it. Thanks.

jasnell pushed a commit that referenced this pull request Mar 27, 2017
These are minor typographical and style improvements to the guide for
writing and running benchmarks.

PR-URL: #12041
Reviewed-By: Nikolai Vavilov <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 27, 2017

Landed in 45df578

@jasnell jasnell closed this Mar 27, 2017
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
These are minor typographical and style improvements to the guide for
writing and running benchmarks.

PR-URL: #12041
Reviewed-By: Nikolai Vavilov <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
2 tasks
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

@joyeecheung
Copy link
Member

This should not land in LTS for the same reason as #11237 (comment)

@Trott Trott deleted the guide-copyedit branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants