Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-domain-abort-on-uncaught #11817

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 12, 2017

test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

Fixes: #11814

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test domain

@Trott Trott added domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests. labels Mar 12, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

Fixes: nodejs#11814
@Trott Trott changed the title test: move flaky test to sequential test: fix flaky test-domain-abort-on-uncaught Mar 12, 2017
@Trott
Copy link
Member Author

Trott commented Mar 12, 2017

@Trott
Copy link
Member Author

Trott commented Mar 12, 2017

@Trott
Copy link
Member Author

Trott commented Mar 12, 2017

Whoops, ran the initial stress test on the wrong architecture.

Stress test again on master (should show failures): https://ci.nodejs.org/job/node-stress-single-test/1122/nodes=armv7-ubuntu1404/console

Stress test on this PR (should succeed): https://ci.nodejs.org/job/node-stress-single-test/1123/nodes=armv7-ubuntu1404/console

@Trott
Copy link
Member Author

Trott commented Mar 12, 2017

Amping up the stress test a bit more to 16 parallel processes.

Master (should fail): https://ci.nodejs.org/job/node-stress-single-test/1127/nodes=armv7-ubuntu1404/console

This PR (should succeed): https://ci.nodejs.org/job/node-stress-single-test/1128/nodes=armv7-ubuntu1404/console

@Trott
Copy link
Member Author

Trott commented Mar 12, 2017

Amping up the stress test a bit more to 32 parallel processes.

Master (should fail): https://ci.nodejs.org/job/node-stress-single-test/1129/nodes=armv7-ubuntu1404/console

This PR (should succeed): https://ci.nodejs.org/job/node-stress-single-test/1130/nodes=armv7-ubuntu1404/console

@Trott
Copy link
Member Author

Trott commented Mar 12, 2017

(Current master is failing the stress test, this PR is passing it.)

@jasnell
Copy link
Member

jasnell commented Mar 15, 2017

New CI since there was a failure on Windows: https://ci.nodejs.org/job/node-test-pull-request/6844/

jasnell pushed a commit that referenced this pull request Mar 16, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: #11817
Fixes: #11814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 16, 2017

Landed in 5e3d536

@jasnell jasnell closed this Mar 16, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 20, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: nodejs#11817
Fixes: nodejs#11814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: nodejs#11817
Fixes: nodejs#11814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: #11817
Fixes: #11814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: #11817
Fixes: #11814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: nodejs/node#11817
Fixes: nodejs/node#11814
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott deleted the flaky-domain-test branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

investigate flaky test-domain-abort-on-uncaught
8 participants