Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip IPv6 test on non-IPv6 systems #11432

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 16, 2017

Until recently, test-dgram-address would fail on machines without IPv6 but still exit
with a successful return code. (It would console.log() the error but not
actually fail.)

Now that the test has been updated such that it will fail the IPv6 part
of the test if there is an error event emitted by the socket, skip the
test on systems not equipped with IPv6.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test dgram

Until recently, test-dgram-address would fail on IPv6 but still exit
with a successful return code. (It would console.log() the error but not
actually fail.)

Now that the test has been updated such that it will fail the IPv6 part
of the test if there is an error event emitted by the socket, skip the
test on systems not equipped with IPv6.
@Trott Trott added dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests. labels Feb 16, 2017
@Trott
Copy link
Member Author

Trott commented Feb 16, 2017

This fixes an issue that is currently causing CI to fail every time for two of the three Raspberry Pi setups we have in CI. I propose not waiting the 48 hours on this one and landing much sooner. /cc @nodejs/testing @cjihrig

@Trott
Copy link
Member Author

Trott commented Feb 16, 2017

@rvagg
Copy link
Member

rvagg commented Feb 16, 2017

I'm gathering this is because of #11271

Also of note that this is only failing on Wheezy systems and not Jessie, so it's something about kernel or libc versions I suppose.

LGTM though! Also +1 on expedited landing. Thanks for jumping on this @Trott

@Trott
Copy link
Member Author

Trott commented Feb 16, 2017

CI again (build failure on one host): https://ci.nodejs.org/job/node-test-pull-request/6456/

Trott added a commit to Trott/io.js that referenced this pull request Feb 17, 2017
Until recently, test-dgram-address would fail on machines without IPv6
but still exit with a successful return code. (It would console.log()
the error but not actually fail.)

Now that the test has been updated such that it will fail the IPv6 part
of the test if there is an error event emitted by the socket, skip the
test on systems not equipped with IPv6.

PR-URL: nodejs#11432
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@Trott
Copy link
Member Author

Trott commented Feb 17, 2017

Landed in d9a14b7

@Trott Trott closed this Feb 17, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 20, 2017
Until recently, test-dgram-address would fail on machines without IPv6
but still exit with a successful return code. (It would console.log()
the error but not actually fail.)

Now that the test has been updated such that it will fail the IPv6 part
of the test if there is an error event emitted by the socket, skip the
test on systems not equipped with IPv6.

PR-URL: nodejs#11432
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
italoacasas pushed a commit that referenced this pull request Feb 21, 2017
Until recently, test-dgram-address would fail on machines without IPv6
but still exit with a successful return code. (It would console.log()
the error but not actually fail.)

Now that the test has been updated such that it will fail the IPv6 part
of the test if there is an error event emitted by the socket, skip the
test on systems not equipped with IPv6.

PR-URL: #11432
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 9, 2017

needs backport PRs in order to land on v6 or v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants