benchmark: unify input to url-related benchmarks #11264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
benchmark
joyeecheung
added
whatwg-url
mscdex
reviewed
Feb 9, 2017
| 'foo=ghi&foo=jkl&foo=mno&foo=pqr&foo=stu&foo=vwxyz', | ||
| manypairs: 'a&b&c&d&e&f&g&h&i&j&k&l&m&n&o&p&q&r&s&t&u&v&w&x&y&z' | ||
| }; | ||
| var inputs = inputs = require('../fixtures/url-inputs.js').searchParams; |
There was a problem hiding this comment.
Ooop, thanks for catching that.
mscdex
reviewed
Feb 9, 2017
| case 'origin': | ||
| case 'searchParams': | ||
| get(n, url, prop); | ||
| break; | ||
| case 'toString': |
There was a problem hiding this comment.
This is covered in legacy-vs-whatwg-url-serialize.js with method="whatwg", also href is an alias of toString so we can just look at the results of href.
|
There's a typo in the second commit message. |
jasnell
approved these changes
Feb 10, 2017
joyeecheung
force-pushed
the
unify-url-bench
branch
from
7a15a68
to
95157e9
Compare
|
@mscdex Thanks for the review, updated, PTAL. |
|
@mscdex Can I have a LGTM please? Thanks! |
joyeecheung
force-pushed
the
unify-url-bench
branch
from
95157e9
to
b486814
Compare
|
Rebased |
watilde
reviewed
Feb 15, 2017
| ws: 'ws://localhost:9229/f46db715-70df-43ad-a359-7f9949f39868', | ||
| javascript: 'javascript:alert("node is awesome");', | ||
| percent: 'https://%E4%BD%A0/foo', | ||
| dot: 'https://example.org/./a/../b/./c' |
There was a problem hiding this comment.
Could we add mailto:[email protected] into here as an example case of mailto protocol?
There was a problem hiding this comment.
That should probably just hit the same code paths as 'javascript:alert("node is awesome");'
|
CI is green, LGTM. |
jasnell
pushed a commit
that referenced
this pull request
Feb 15, 2017
PR-URL: #11264 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Brian White <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Feb 15, 2017
PR-URL: #11264 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Brian White <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Feb 15, 2017
PR-URL: #11264 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Brian White <[email protected]>
|
Landed in e571fd4...7ee9504 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 16, 2017
PR-URL: nodejs#11264 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Brian White <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 16, 2017
PR-URL: nodejs#11264 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Brian White <[email protected]>
TimothyGu
pushed a commit
to TimothyGu/node
that referenced
this pull request
Feb 18, 2017
Backport-of: nodejs#11264
4 tasks
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 20, 2017
Backport-of: nodejs#11264
italoacasas
pushed a commit
that referenced
this pull request
Feb 22, 2017
PR-URL: #11264 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Brian White <[email protected]>
italoacasas
pushed a commit
that referenced
this pull request
Feb 22, 2017
PR-URL: #11264 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Brian White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves common input to url-related benchmarks into
fixturesand removes duplicate benchmarksurl-parse.jsis covered bylegacy-vs-whatwg-url-parse.jswithmethod="legacy"whatwg-url-properties.jsis covered bylegacy-vs-whatwg-url-serialize.jswithmethod="legacy"(it is still worth keeping becauselegacy-vs-whatwg-url-get-prop.jsbenchmarks getting all properties at once whilewhatwg-url-properties.jsbenchmarks getting/setting individual property)Some of the search params cases are taken from #11234 per suggestion from #11170 (review)
cc @nodejs/url
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
benchmark, url