Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test-http-unix-socket.js - var -> const, assert.equal -> assert.strictEqual #10072

Closed
wants to merge 1 commit into from
Closed

test: test-http-unix-socket.js - var -> const, assert.equal -> assert.strictEqual #10072

wants to merge 1 commit into from

Conversation

davidmarkclements
Copy link
Member

@davidmarkclements davidmarkclements commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, crypto

Description of change

changes assert.equal to assert.strictEqual to ensure specificity

changes var declarations to const to take advantage of es6 immutable bindings


edit: correct subsystem


@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@santigimeno
Copy link
Member

LGTM other than the commit message should follow these rules

@davidmarkclements
Copy link
Member Author

@santigimeno specifically the column count or is there also something else?

@santigimeno
Copy link
Member

@davidmarkclements also the format: subsystem: commit message. In this case it could be: test: refactor test-http-unix-socket

@davidmarkclements davidmarkclements changed the title test-http-unix-socket.js: var -> const, assert.equal -> assert.strictEqual test: test-http-unix-socket.js - var -> const, assert.equal -> assert.strictEqual Dec 1, 2016
server.close(function(error) {
assert.equal(error, undefined);
assert.strictEqual(error, undefined);
server.close(function(error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we are editing this, can you please use common.mustCall in those two functions?

@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 2, 2016
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to replace the req.on('error', ...) handler if common.fail() instead of explicitly calling process.exit().

@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Dec 3, 2016
Use `common.mustCall()` and `common.fail()` where appropriate.

Change `assert.equal` to `assert.strictEqual` to ensure specificity.

Change var declarations to const to take advantage of ES6 immutable
bindings.
@Trott
Copy link
Member

Trott commented Dec 7, 2016

@cjihrig @mcollina I've made changes per your comments and force pushed them to @davidmarkclements's branch. PTAL.

@Trott
Copy link
Member

Trott commented Dec 7, 2016

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 8, 2016
Use `common.mustCall()` and `common.fail()` where appropriate.

Change `assert.equal` to `assert.strictEqual` to ensure specificity.

Change var declarations to const to take advantage of ES6 immutable
bindings.

PR-URL: nodejs#10072
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@Trott
Copy link
Member

Trott commented Dec 8, 2016

Landed in 444b907.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 8, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 13, 2016
Use `common.mustCall()` and `common.fail()` where appropriate.

Change `assert.equal` to `assert.strictEqual` to ensure specificity.

Change var declarations to const to take advantage of ES6 immutable
bindings.

PR-URL: #10072
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@italoacasas italoacasas mentioned this pull request Dec 15, 2016
MylesBorins pushed a commit that referenced this pull request Jan 16, 2017
Use `common.mustCall()` and `common.fail()` where appropriate.

Change `assert.equal` to `assert.strictEqual` to ensure specificity.

Change var declarations to const to take advantage of ES6 immutable
bindings.

PR-URL: #10072
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@MylesBorins MylesBorins added dont-land-on-v4.x and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Jan 16, 2017
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Use `common.mustCall()` and `common.fail()` where appropriate.

Change `assert.equal` to `assert.strictEqual` to ensure specificity.

Change var declarations to const to take advantage of ES6 immutable
bindings.

PR-URL: #10072
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
Use `common.mustCall()` and `common.fail()` where appropriate.

Change `assert.equal` to `assert.strictEqual` to ensure specificity.

Change var declarations to const to take advantage of ES6 immutable
bindings.

PR-URL: #10072
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants