Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please document the stdio array in cluster.settings #47705

Closed
aral opened this issue Apr 24, 2023 · 2 comments
Closed

Please document the stdio array in cluster.settings #47705

aral opened this issue Apr 24, 2023 · 2 comments
Labels
cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@aral
Copy link

aral commented Apr 24, 2023

Affected URL(s)

https://nodejs.org/dist/latest-v20.x/docs/api/cluster.html#clustersettings

Description of the problem

The docs state that the stdio property of cluster.settings is an Array but they do not document what the array should be populated with.

It should link to https://nodejs.org/dist/latest-v20.x/docs/api/child_process.html#optionsstdio if it uses the same structure (I’m assuming it does, as child_process.fork() does.

@aral aral added the doc Issues and PRs related to the documentations. label Apr 24, 2023
@rezwanahmedsami
Copy link

Can you please tell me in more brief explain?

@VoltrexKeyva VoltrexKeyva added the cluster Issues and PRs related to the cluster subsystem. label Apr 24, 2023
@aduh95
Copy link
Contributor

aduh95 commented May 21, 2023

Would you like to open a PR to address this? Please don't ask for permission or if someone else is working on it, just opening the PR is better.

@aduh95 aduh95 added the good first issue Issues that are suitable for first-time contributors. label May 21, 2023
Karnav123 added a commit to Karnav123/node that referenced this issue May 22, 2023
lpinca pushed a commit to Karnav123/node that referenced this issue May 29, 2023
MoLow pushed a commit to MoLow/node that referenced this issue Jul 6, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Development

No branches or pull requests

4 participants