Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-fs-read-type fails on IBM i #36925

Closed
Trott opened this issue Jan 14, 2021 · 9 comments
Closed

test-fs-read-type fails on IBM i #36925

Trott opened this issue Jan 14, 2021 · 9 comments
Assignees
Labels
fs Issues and PRs related to the fs subsystem / file system. ibm i Issues and PRs related to the IBM i platform.

Comments

@Trott
Copy link
Member

Trott commented Jan 14, 2021

I think it fails every time now that 72b678a was merged a day or two ago. Since IBM i only runs in the nightly CI job, this issue wasn't apparent during pull request reviews.

Wha't's the right thing to do here? Leave it for now and someone on @nodejs/platform-ibmii will take a look? Add this to the list of skipped tests on IBM i in parallel.status? Both? Something else?

https://ci.nodejs.org/job/node-test-commit-ibmi/223

not ok 844 parallel/test-fs-read-type
  ---
  duration_ms: 1.622
  severity: fail
  exitcode: 1
  stack: |-
    /home/iojs/build/workspace/node-test-commit-ibmi/nodes/ibmi72-ppc64/test/parallel/test-fs-read-type.js:238
      if (err.code !== 'EFBIG') throw err;
                                ^
    
    Error: UNKNOWN: unknown error, read
        at Object.readSync (node:fs:634:3)
        at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-ibmi/nodes/ibmi72-ppc64/test/parallel/test-fs-read-type.js:229:6)
        at Module._compile (node:internal/modules/cjs/loader:1108:14)
        at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10)
        at Module.load (node:internal/modules/cjs/loader:973:32)
        at Function.Module._load (node:internal/modules/cjs/loader:813:14)
        at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
        at node:internal/main/run_main_module:17:47 {
      errno: -127,
      syscall: 'read',
      code: 'UNKNOWN'
    }
  ...

@nodejs/platform-ibmi @RaisinTen

@Trott Trott added fs Issues and PRs related to the fs subsystem / file system. ibm i Issues and PRs related to the IBM i platform. labels Jan 14, 2021
@ThePrez
Copy link
Contributor

ThePrez commented Jan 14, 2021

cc @nodejs/platform-ibmi
I vote leave this one for know, and assign to @dmabupt and me

@Trott
Copy link
Member Author

Trott commented Jan 14, 2021

I vote leave this one for know, and assign to @dmabupt and me

Thanks. I assigned to you. It won't let me assign to @dmabupt as well because they are not a member of the org. Should they be added to @nodejs/platform-ibmi? Or is the omission there intentional?

@richardlau
Copy link
Member

I vote leave this one for know, and assign to @dmabupt and me

Thanks. I assigned to you. It won't let me assign to @dmabupt as well because they are not a member of the org. Should they be added to @nodejs/platform-ibmi? Or is the omission there intentional?

They were invited to join the team according to nodejs/admin#490 (comment)

@RaisinTen
Copy link
Contributor

I'm sorry this happened. Perhaps adding a check for err.code !== 'UNKNOWN' would do the trick:

if (err.code !== 'EFBIG') throw err;

-  if (err.code !== 'EFBIG') throw err;
+  if (err.code !== 'EFBIG' && err.code !== 'UNKNOWN') throw err;

@richardlau
Copy link
Member

I'm sorry this happened. Perhaps adding a check for err.code !== 'UNKNOWN' would do the trick:

if (err.code !== 'EFBIG') throw err;

-  if (err.code !== 'EFBIG') throw err;
+  if (err.code !== 'EFBIG' && err.code !== 'UNKNOWN') throw err;

I'd rather see if the UNKNOWN could be mapped to something more informative in the Node.js/libuv layer. I think errno: -127 is EOVERFLOW:

-bash-4.4$ grep 127 /usr/include/errno.h
#define EOVERFLOW       127     /* value too large to be stored in data type */
-bash-4.4$

@ThePrez
Copy link
Contributor

ThePrez commented Jan 14, 2021

I vote leave this one for know, and assign to @dmabupt and me

Thanks. I assigned to you. It won't let me assign to @dmabupt as well because they are not a member of the org. Should they be added to @nodejs/platform-ibmi? Or is the omission there intentional?

@dmabupt should definitely be added to the @nodejs/platform-ibmi team. @dmabupt, please check to see if you have a pending invite still, or maybe you need to be re-invited.

@RaisinTen RaisinTen reopened this Jan 14, 2021
@RaisinTen
Copy link
Contributor

Sorry again, I misclicked.

@mhdawson
Copy link
Member

Invited @dmabupt to the team.

Trott pushed a commit that referenced this issue Jan 19, 2021
PR-URL: #36986
Refs: #34410
Refs: #36925
Refs: #36929
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
ruyadorno pushed a commit that referenced this issue Jan 22, 2021
PR-URL: #36986
Refs: #34410
Refs: #36925
Refs: #36929
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
ruyadorno pushed a commit that referenced this issue Jan 25, 2021
PR-URL: #36986
Refs: #34410
Refs: #36925
Refs: #36929
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@mhdawson
Copy link
Member

@dmabupt have you had a chance to look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. ibm i Issues and PRs related to the IBM i platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants