Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test-http2-server-rst-stream #16688

Closed
Trott opened this issue Nov 2, 2017 · 3 comments
Closed

Investigate flaky test-http2-server-rst-stream #16688

Trott opened this issue Nov 2, 2017 · 3 comments
Assignees
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@Trott
Copy link
Member

Trott commented Nov 2, 2017

  • Version: v10.0.0-pre
  • Platform: win2008r2-vs2017
  • Subsystem: test, http2

https://ci.nodejs.org/job/node-test-binary-windows/12447/COMPILED_BY=vs2015,RUNNER=win2008r2-vs2017,RUN_SUBSET=1/console:

not ok 241 parallel/test-http2-server-rst-stream
  ---
  duration_ms: 0.398
  severity: fail
  stack: |-
    (node:7084) ExperimentalWarning: The http2 module is an experimental API.
    assert.js:42
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: rstWithRefuse is not match rstCode
        at ClientHttp2Stream.req.on.common.mustCall (c:\workspace\node-test-binary-windows\test\parallel\test-http2-server-rst-stream.js:55:14)
        at ClientHttp2Stream.<anonymous> (c:\workspace\node-test-binary-windows\test\common\index.js:522:15)
        at emitOne (events.js:130:20)
        at ClientHttp2Stream.emit (events.js:221:7)
        at emit (internal/http2/core.js:140:8)
        at _combinedTickCallback (internal/process/next_tick.js:141:11)
        at process._tickCallback (internal/process/next_tick.js:180:9)

@nodejs/http2 @nodejs/testing @nodejs/platform-windows @nodejs/build

@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform. labels Nov 2, 2017
@apapirovski
Copy link
Member

Yeah, I think this test just makes too many assumptions about the flow. I've had it on my list for a while. I believe it also fails on node-chakracore and they marked it as flaky.

Will work on it shortly so assigning to myself.

@tniessen
Copy link
Member

tniessen commented Nov 2, 2017

I believe I saw this failing locally as well.

@jasnell jasnell closed this as completed in 3a977fc Nov 2, 2017
cjihrig pushed a commit to cjihrig/node that referenced this issue Nov 6, 2017
PR-URL: nodejs#16690
Fixes: nodejs#16688
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
gibfahn pushed a commit that referenced this issue Nov 14, 2017
PR-URL: #16690
Fixes: #16688
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants