Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly docs missing #14930

Closed
vsemozhetbyt opened this issue Aug 18, 2017 · 9 comments
Closed

Nightly docs missing #14930

vsemozhetbyt opened this issue Aug 18, 2017 · 9 comments
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Aug 18, 2017

@vsemozhetbyt vsemozhetbyt added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Aug 18, 2017
@Trott
Copy link
Member

Trott commented Aug 19, 2017

#13482 seems like a likely source of the issue.

@tniessen
Copy link
Member

This should have been fixed in #14932 (8850fd4). Feel free to reopen if the nightly docs are still missing tomorrow.

MylesBorins pushed a commit that referenced this issue Sep 10, 2017
`gen-doc` always calls `gen-json`, which means it's impossible to
generate html docs. Changed this to pass in the command the user wants
to run.

PR-URL: #14932
Fixes: #14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this issue Sep 12, 2017
`gen-doc` always calls `gen-json`, which means it's impossible to
generate html docs. Changed this to pass in the command the user wants
to run.

PR-URL: #14932
Fixes: #14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@vsemozhetbyt vsemozhetbyt reopened this Sep 17, 2017
@vsemozhetbyt
Copy link
Contributor Author

cc @nodejs/build

@maclover7
Copy link
Contributor

Opened #15447 to try and fix this

addaleax pushed a commit to ayojs/ayo that referenced this issue Sep 17, 2017
Will break YAML parsing!

See details in the PR.

PR-URL: nodejs/node#15447
Fixes: nodejs/node#14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this issue Sep 28, 2017
Will break YAML parsing!

See details in the PR.

PR-URL: #15447
Fixes: #14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this issue Sep 29, 2017
Will break YAML parsing!

See details in the PR.

PR-URL: #15447
Fixes: #14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this issue Oct 3, 2017
Will break YAML parsing!

See details in the PR.

PR-URL: #15447
Fixes: #14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this issue Oct 3, 2017
Will break YAML parsing!

See details in the PR.

PR-URL: #15447
Fixes: #14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@vsemozhetbyt vsemozhetbyt reopened this Oct 5, 2017
@vsemozhetbyt
Copy link
Contributor Author

Possible cause (like #15447): #15680

We should make some safety device for this.

@vsemozhetbyt
Copy link
Contributor Author

Fixed in 0c49038

@maclover7
Copy link
Contributor

Pending issue is nodejs/build#887, personally still think best solution here is to compile docs with each node-test-commit run.

MylesBorins pushed a commit that referenced this issue Oct 11, 2017
Will break YAML parsing!

See details in the PR.

PR-URL: #15447
Fixes: #14930
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

No branches or pull requests

4 participants