Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arguments property of ReferenceError instance? #11558

Closed
vsemozhetbyt opened this issue Feb 25, 2017 · 3 comments
Closed

arguments property of ReferenceError instance? #11558

vsemozhetbyt opened this issue Feb 25, 2017 · 3 comments
Labels
doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. v8 engine Issues and PRs related to the V8 dependency.

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Feb 25, 2017

  • Version:
  • Platform: Windows 7 x64
  • Subsystem: doc, errors

errors.md states:

ReferenceError instances will have an error.arguments property whose value is an array containing a single element: a string representing the variable that was not defined.

However, it seems this property does not exixst anymore in the actual Node.js versions:

try {
  doesNotExist;
} catch (err) {
  console.log(Object.getOwnPropertyNames(err));
}
  // v8 4.5.103.45 (Node.js 4.8.0 x64)

[ 'stack', 'message' ]

  // v8 5.1.281.93 (Node.js 6.10.0 x64)

[ 'stack', 'message' ]

  // v8 5.5.372.40 (Node.js 7.6.0 x64)

[ 'stack', 'message' ]

  // v8 5.6.326.55 (Node.js 8.0.0-nightly20170222a1802e670d x64)

[ 'stack', 'message' ]

  // v8 5.8.202 (Node.js 8.0.0-pre x64)

[ 'stack', 'message' ]

Is this an unintended loss or is this property removed intentionally?

@addaleax addaleax added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. v8 engine Issues and PRs related to the V8 dependency. labels Feb 25, 2017
@joyeecheung
Copy link
Member

I am guessing error.arguments is just a non-standard property and went away quitely in a V8 update?(the spec doesn't specify such a property).

@vsemozhetbyt
Copy link
Contributor Author

Should I remove the statement and the code example?

@bnoordhuis
Copy link
Member

@vsemozhetbyt Good idea.

@jasnell jasnell closed this as completed in 6aa18aa Mar 1, 2017
addaleax pushed a commit that referenced this issue Mar 5, 2017
* add semicolons in examples
* fix indentation in code example
* add spaces in code examples
* console.log() -> console.error()
* fix level of headings
* update comment code example
* delete obsolete info and example

Fixes: #11558
PR-URL: #11566
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this issue Apr 17, 2017
* add semicolons in examples
* fix indentation in code example
* add spaces in code examples
* console.log() -> console.error()
* fix level of headings
* update comment code example
* delete obsolete info and example

Fixes: #11558
PR-URL: #11566
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this issue Apr 19, 2017
* add semicolons in examples
* fix indentation in code example
* add spaces in code examples
* console.log() -> console.error()
* fix level of headings
* update comment code example
* delete obsolete info and example

Fixes: #11558
PR-URL: #11566
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
andrew749 pushed a commit to michielbaird/node that referenced this issue Jul 19, 2017
* add semicolons in examples
* fix indentation in code example
* add spaces in code examples
* console.log() -> console.error()
* fix level of headings
* update comment code example
* delete obsolete info and example

Fixes: nodejs/node#11558
PR-URL: nodejs/node#11566
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants