Skip to content

Commit

Permalink
deps: remove bogus V8 DCHECK
Browse files Browse the repository at this point in the history
Refs: #54077 (comment)
PR-URL: #54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
  • Loading branch information
targos committed Aug 16, 2024
1 parent 5355603 commit fba06eb
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.12',
'v8_embedder_string': '-node.13',

##### V8 defaults for Node.js #####

Expand Down
1 change: 0 additions & 1 deletion deps/v8/src/ast/scopes.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2714,7 +2714,6 @@ void Scope::AllocateScopeInfosRecursively(

// Allocate ScopeInfos for inner scopes.
for (Scope* scope = inner_scope_; scope != nullptr; scope = scope->sibling_) {
DCHECK_GT(scope->UniqueIdInScript(), UniqueIdInScript());
DCHECK_IMPLIES(scope->sibling_, scope->sibling_->UniqueIdInScript() !=
scope->UniqueIdInScript());
if (!scope->is_function_scope() ||
Expand Down

0 comments on commit fba06eb

Please sign in to comment.