Apply suggestions from code review

nodejs · Apr 8, 2021 · ebea6f5 · ebea6f5
1 parent 29a37fc
commit ebea6f5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/internal/stream_base_commons.js b/lib/internal/stream_base_commons.js
@@ -205,8 +205,11 @@ function onStreamRead(arrayBuffer) {
     return;
   }
 
-  // note: handle should never deliver any more read events after this point.
-  // (equivalently, it should have called readStop on itself alread).
+  // After seeing EOF, most streams will be closed permanently,
+  // and will not deliver any more read events after this point.
+  // (equivalently, it should have called readStop on itself already).
+  // Some streams may be reset and explicitly started again with a call
+  // to readStart, such as TTY.
 
   if (nread !== UV_EOF) {
     // CallJSOnreadMethod expects the return value to be a buffer.

diff --git a/src/crypto/crypto_tls.cc b/src/crypto/crypto_tls.cc
@@ -1082,7 +1082,6 @@ void TLSWrap::OnStreamRead(ssize_t nread, const uv_buf_t& buf) {
   Debug(this, "Read %zd bytes from underlying stream", nread);
 
   // Ignore everything after close_notify (rfc5246#section-7.2.1)
-  // TODO: unregister our interest in read events
   if (eof_)
     return;