Merge branch 'main' into improve-webstreams-adapters-coverage

.eslintignore

@@ -5,6 +5,7 @@ test/fixtures
 test/message/esm_display_syntax_error.mjs
 tools/icu
 tools/lint-md/lint-md.mjs
+tools/github_reporter
 benchmark/tmp
 benchmark/fixtures
 doc/**/*.js

.eslintrc.js

@@ -53,10 +53,10 @@ module.exports = {
   overrides: [
     {
       files: [
-        'test/es-module/test-esm-type-flag.js',
-        'test/es-module/test-esm-type-flag-alias.js',
         '*.mjs',
         'test/es-module/test-esm-example-loader.js',
+        'test/es-module/test-esm-type-flag.js',
+        'test/es-module/test-esm-type-flag-alias.js',
       ],
       parserOptions: { sourceType: 'module' },
     },
@@ -111,6 +111,22 @@ module.exports = {
         },
       ] },
     },
+    {
+      files: [
+        'lib/internal/modules/**/*.js',
+      ],
+      rules: {
+        'curly': 'error',
+      },
+    },
+    {
+      files: [
+        'lib/internal/test_runner/**/*.js',
+      ],
+      rules: {
+        'node-core/set-proto-to-null-in-object': 'error',
+      },
+    },
   ],
   rules: {
     // ESLint built-in rules
@@ -306,6 +322,7 @@ module.exports = {
     'jsdoc/newline-after-description': 'off',
     'jsdoc/require-returns-description': 'off',
     'jsdoc/valid-types': 'off',
+    'jsdoc/no-defaults': 'off',
     'jsdoc/no-undefined-types': 'off',
     'jsdoc/require-param': 'off',
     'jsdoc/check-tag-names': 'off',
@@ -327,6 +344,7 @@ module.exports = {
     DecompressionStream: 'readable',
     fetch: 'readable',
     FormData: 'readable',
+    navigator: 'readable',
     ReadableStream: 'readable',
     ReadableStreamDefaultReader: 'readable',
     ReadableStreamBYOBReader: 'readable',

.github/CODEOWNERS

@@ -11,53 +11,60 @@
 # tsc
 
 /.github/CODEOWNERS @nodejs/tsc
-/GOVERNANCE.md @nodejs/tsc
-/onboarding.md @nodejs/tsc
+/.github/PULL_REQUEST_TEMPLATE.md @nodejs/tsc
+/.github/ISSUE_TEMPLATE/* @nodejs/tsc
 /CODE_OF_CONDUCT.md @nodejs/tsc
 /CONTRIBUTING.md @nodejs/tsc
-/LICENSE @nodejs/tsc
 /doc/contributing/*.md @nodejs/tsc
+/GOVERNANCE.md @nodejs/tsc
+/LICENSE @nodejs/tsc
+/onboarding.md @nodejs/tsc
+
+# website
+/doc/api_assets @nodejs/website
+/doc/template.html @nodejs/website
+/tools/doc @nodejs/website
 
 # streams
 
 /lib/_stream* @nodejs/streams
+/lib/internal/streams/* @nodejs/streams
 /lib/stream.js @nodejs/streams
 /lib/stream/* @nodejs/streams
-/lib/internal/streams/* @nodejs/streams
 
 # net
 
 /deps/ada @nodejs/url
 /deps/cares @nodejs/net
-/doc/api/dns.md @nodejs/net
 /doc/api/dgram.md @nodejs/net
+/doc/api/dns.md @nodejs/net
 /doc/api/net.md @nodejs/net
 /lib/dgram.js @nodejs/net
 /lib/dns.js @nodejs/net
-/lib/net.js @nodejs/net
-/lib/url.js @nodejs/url
 /lib/internal/dgram.js @nodejs/net
 /lib/internal/dns/* @nodejs/net
+/lib/internal/js_stream_socket.js @nodejs/net
 /lib/internal/net.js @nodejs/net
 /lib/internal/socket_list.js @nodejs/net
-/lib/internal/js_stream_socket.js @nodejs/net
 /lib/internal/url.js @nodejs/url
-/src/node_url.* @nodejs/url
+/lib/net.js @nodejs/net
+/lib/url.js @nodejs/url
 /src/cares_wrap.cc @nodejs/net
 /src/connect_wrap.* @nodejs/net
 /src/connection_wrap.* @nodejs/net
 /src/node_sockaddr* @nodejs/net
+/src/node_url.* @nodejs/url
 /src/tcp_wrap.* @nodejs/net
 /src/udp_wrap.* @nodejs/net
 
 # tls/crypto
 
+/lib/crypto.js @nodejs/crypto
 /lib/internal/crypto/* @nodejs/crypto
 /lib/internal/tls/* @nodejs/crypto @nodejs/net
-/lib/crypto.js @nodejs/crypto
 /lib/tls.js @nodejs/crypto @nodejs/net
-/src/node_crypto* @nodejs/crypto
 /src/crypto/* @nodejs/crypto
+/src/node_crypto* @nodejs/crypto
 
 # http
 
@@ -80,23 +87,23 @@
 
 # modules, including loaders
 
-/doc/api/esm.md @nodejs/modules @nodejs/loaders
-/doc/api/module.md @nodejs/modules @nodejs/loaders
-/doc/api/modules.md @nodejs/modules @nodejs/loaders
-/doc/api/packages.md @nodejs/modules @nodejs/loaders
-/lib/internal/bootstrap/realm.js @nodejs/modules @nodejs/loaders
-/lib/internal/modules/* @nodejs/modules @nodejs/loaders
-/lib/internal/process/esm_loader.js @nodejs/modules @nodejs/loaders
-/lib/internal/process/execution.js @nodejs/modules @nodejs/loaders
-/lib/module.js @nodejs/modules @nodejs/loaders
-/src/module_wrap* @nodejs/modules @nodejs/loaders @nodejs/vm
+/doc/api/esm.md @nodejs/loaders
+/doc/api/module.md @nodejs/loaders
+/doc/api/modules.md @nodejs/loaders
+/doc/api/packages.md @nodejs/loaders
+/lib/internal/bootstrap/realm.js @nodejs/loaders
+/lib/internal/modules/* @nodejs/loaders
+/lib/internal/process/esm_loader.js @nodejs/loaders
+/lib/internal/process/execution.js @nodejs/loaders
+/lib/module.js @nodejs/loaders
+/src/module_wrap* @nodejs/loaders @nodejs/vm
 
 # Node-API
 
-/src/node_api* @nodejs/node-api
-/src/js_native_api* @nodejs/node-api
-/doc/contributing/adding-new-napi-api.md @nodejs/node-api
 /doc/api/n-api.md @nodejs/node-api
+/doc/contributing/adding-new-napi-api.md @nodejs/node-api
+/src/js_native_api* @nodejs/node-api
+/src/node_api* @nodejs/node-api
 
 # gyp
 
@@ -110,19 +117,19 @@
 /doc/api/wasi.md @nodejs/wasi
 /lib/wasi.js @nodejs/wasi
 /src/node_wasi* @nodejs/wasi
-/test/wasi/ @nodejs/wasi
 /test/fixtures/wasi/ @nodejs/wasi
+/test/wasi/ @nodejs/wasi
 
 # Startup
 
-/test/parallel/test-snapshot-* @nodejs/startup
-/test/parallel/test-bootstrap-* @nodejs/startup
 /benchmark/misc/startup.js @nodejs/startup
-/src/node.cc @nodejs/startup
-/src/node_realm* @nodejs/startup @nodejs/realm
+/lib/internal/bootstrap/* @nodejs/startup
 /src/node_builtins* @nodejs/startup
+/src/node_realm* @nodejs/startup @nodejs/realm
 /src/node_snapshot* @nodejs/startup
-/lib/internal/bootstrap/* @nodejs/startup
+/src/node.cc @nodejs/startup
+/test/parallel/test-bootstrap-* @nodejs/startup
+/test/parallel/test-snapshot-* @nodejs/startup
 /tools/snapshot/* @nodejs/startup
 
 # V8
@@ -137,11 +144,12 @@
 
 # Test runner
 
-/test/parallel/test-runner-* @nodejs/test_runner
 /doc/api/test.md @nodejs/test_runner
-/lib/test.js @nodejs/test_runner
 /lib/internal/main/test_runner.js @nodejs/test_runner
 /lib/internal/test_runner/* @nodejs/test_runner
+/lib/test.js @nodejs/test_runner
+/lib/test/reporters.js @nodejs/test_runner
+/test/parallel/test-runner-* @nodejs/test_runner
 
 # Single Executable Applications
 /deps/postject @nodejs/single-executable
@@ -154,6 +162,13 @@
 /tools/dep_updaters/update-postject.sh @nodejs/single-executable
 
 # Permission Model
-/src/permission/* @nodejs/security-wg
 /doc/api/permissions.md @nodejs/security-wg
 /lib/internal/process/permission.js @nodejs/security-wg
+/src/permission/* @nodejs/security-wg
+
+# Dependency Update Tools
+
+/.github/workflows/tools.yml @nodejs/security-wg
+/.github/workflows/update-openssl.yml @nodejs/security-wg
+/.github/workflows/update-v8.yml @nodejs/security-wg @nodejs/v8-update
+/tools/dep_updaters/* @nodejs/security-wg

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,15 +1,18 @@
 <!--
-Before submitting a pull request, please read
-https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.
+Before submitting a pull request, please read:
 
-Commit message formatting guidelines:
-https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
+- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
+- the commit message formatting guidelines at
+  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
 
 For code changes:
 1. Include tests for any bug fixes or new features.
 2. Update documentation if relevant.
 3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.
 
+If you believe this PR should be highlighted in the Node.js CHANGELOG
+please add the `notable-change` label.
+
 Developer's Certificate of Origin 1.1
 
 By making a contribution to this project, I certify that:

.github/workflows/auto-start-ci.yml

@@ -34,7 +34,7 @@ jobs:
                   --label 'request-ci' \
                   --json 'number' \
                   -t '{{ range . }}{{ .number }} {{ end }}' \
-                  --limit 100)
+                  --limit 5)
           echo "numbers=$numbers" >> $GITHUB_OUTPUT
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -46,19 +46,19 @@ jobs:
     if: needs.get-prs-for-ci.outputs.numbers != ''
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab  # v3.5.2
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744  # v3.6.0
         with:
           persist-credentials: false
 
       - name: Install Node.js
-        uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c  # v3.6.0
+        uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d  # v3.8.1
         with:
           node-version: ${{ env.NODE_VERSION }}
 
-      - name: Install node-core-utils
-        run: npm install -g node-core-utils
+      - name: Install @node-core/utils
+        run: npm install -g @node-core/utils
 
-      - name: Setup node-core-utils
+      - name: Setup @node-core/utils
         run: |
           ncu-config set username ${{ secrets.JENKINS_USER }}
           ncu-config set token "${{ secrets.GH_USER_TOKEN }}"

.github/workflows/build-tarball.yml

@@ -39,11 +39,11 @@ jobs:
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab  # v3.5.2
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744  # v3.6.0
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@57ded4d7d5e986d7296eab16560982c6dd7c923b  # v4.6.0
+        uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1  # v4.7.0
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information
@@ -65,11 +65,11 @@ jobs:
     needs: build-tarball
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab  # v3.5.2
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744  # v3.6.0
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@57ded4d7d5e986d7296eab16560982c6dd7c923b  # v4.6.0
+        uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1  # v4.7.0
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information
@@ -94,4 +94,4 @@ jobs:
       - name: Test
         run: |
           cd $TAR_DIR
-          make run-ci -j2 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9"
+          make run-ci -j2 V=1 TEST_CI_ARGS="-p dots --node-args='--test-reporter=spec' --measure-flakiness 9"

.github/workflows/build-windows.yml

@@ -38,11 +38,11 @@ jobs:
       fail-fast: false
     runs-on: ${{ matrix.windows }}
     steps:
-      - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab  # v3.5.2
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744  # v3.6.0
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@57ded4d7d5e986d7296eab16560982c6dd7c923b  # v4.6.0
+        uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1  # v4.7.0
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Install deps

.github/workflows/close-stale-feature-requests.yml

@@ -48,7 +48,7 @@ jobs:
           close-issue-message: ${{ env.CLOSE_MESSAGE }}
           stale-issue-message: ${{ env.WARN_MESSAGE }}
           only-labels: feature request
-          exempt-pr-labels: never-stale
+          exempt-issue-labels: never-stale
           # max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits
           operations-per-run: 500
           remove-stale-when-updated: true

.github/workflows/close-stale-pull-requests.yml

@@ -0,0 +1,59 @@
+name: Close stale pull requests
+on:
+  workflow_dispatch:
+    inputs:
+      endDate:
+        description: stop processing PRs after this date
+        required: false
+        type: string
+
+# yamllint disable rule:empty-lines
+env:
+  CLOSE_MESSAGE: >
+    This pull request was opened more than a year ago and there has
+    been no activity in the last 6 months. We value your contribution
+    but since it has not progressed in the last 6 months it is being
+    closed. If you feel closing this pull request is not the right thing
+    to do, please leave a comment.
+
+  WARN_MESSAGE: >
+    This pull request was opened more than a year ago and there has
+    been no activity in the last 5 months. We value your contribution
+    but since it has not progressed in the last 5 months it is being
+    marked stale and will be closed if there is no progress in the
+    next month. If you feel that is not the right thing to do please
+    comment on the pull request.
+# yamllint enable
+
+permissions:
+  contents: read
+
+jobs:
+  stale:
+    permissions:
+      pull-requests: write  # for actions/stale to close stale PRs
+    if: github.repository == 'nodejs/node'
+    runs-on: ubuntu-latest
+    steps:
+      - name: Set default end date which is 1 year ago
+        run: echo "END_DATE=$(date --date='525600 minutes ago' --rfc-2822)"  >> "$GITHUB_ENV"
+      - name: if date set in event override the default end date
+        env:
+          END_DATE_INPUT_VALUE: ${{ github.event.inputs.endDate }}
+        if: ${{ github.event.inputs.endDate != '' }}
+        run: echo "END_DATE=$END_DATE_INPUT_VALUE"  >> "$GITHUB_ENV"
+      - uses: mhdawson/stale@453d6581568dc43dbe345757f24408d7b451c651  # PR to add support for endDate
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          end-date: ${{ env.END_DATE }}
+          days-before-issue-stale: -1
+          days-before-issue-close: -1
+          days-before-stale: 150
+          days-before-close: 30
+          stale-issue-label: stale
+          close-issue-message: ${{ env.CLOSE_MESSAGE }}
+          stale-issue-message: ${{ env.WARN_MESSAGE }}
+          exempt-pr-labels: never-stale
+          # max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits
+          operations-per-run: 500
+          remove-stale-when-updated: true