Skip to content

Commit

Permalink
benchmark: remove unreachable return
Browse files Browse the repository at this point in the history
PR-URL: #25883
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
  • Loading branch information
ZYSzys authored and danbev committed Feb 7, 2019
1 parent 4e07d21 commit b4e670d
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 6 deletions.
1 change: 0 additions & 1 deletion benchmark/_cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ function CLI(usage, settings) {
} else {
// Bad case, abort
this.abort(usage);
return;
}
}
}
Expand Down
1 change: 0 additions & 1 deletion benchmark/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ Benchmark.prototype._run = function() {
child.on('close', (code) => {
if (code) {
process.exit(code);
return;
}

if (queueIndex + 1 < self.queue.length) {
Expand Down
2 changes: 0 additions & 2 deletions benchmark/compare.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ const cli = CLI(`usage: ./node compare.js [options] [--] <category> ...

if (!cli.optional.new || !cli.optional.old) {
cli.abort(cli.usage);
return;
}

const binaries = ['old', 'new'];
Expand Down Expand Up @@ -98,7 +97,6 @@ if (showProgress) {
child.once('close', (code) => {
if (code) {
process.exit(code);
return;
}
if (showProgress) {
progress.completeRun(job);
Expand Down
1 change: 0 additions & 1 deletion benchmark/run.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ if (format === 'csv') {
child.once('close', (code) => {
if (code) {
process.exit(code);
return;
}

// If there are more benchmarks execute the next
Expand Down
1 change: 0 additions & 1 deletion benchmark/scatter.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ const cli = CLI(`usage: ./node scatter.js [options] [--] <filename>

if (cli.items.length !== 1) {
cli.abort(cli.usage);
return;
}

// Create queue from the benchmarks list such both node versions are tested
Expand Down

0 comments on commit b4e670d

Please sign in to comment.