Skip to content

Commit

Permalink
http: explain the unused argument in IncomingMessage._read
Browse files Browse the repository at this point in the history
PR-URL: #37275
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
  • Loading branch information
Ayase-252 authored and dnlup committed Feb 10, 2021
1 parent ad3ebed commit 9fa1f68
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion lib/_http_incoming.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,10 @@ IncomingMessage.prototype.setTimeout = function setTimeout(msecs, callback) {
return this;
};


// Argument n cannot be factored out due to the overhead of
// argument adaptor frame creation inside V8 in case that number of actual
// arguments is different from expected arguments.
// Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10201
IncomingMessage.prototype._read = function _read(n) {
if (!this._consuming) {
this._readableState.readingMore = false;
Expand Down

0 comments on commit 9fa1f68

Please sign in to comment.