fs: extract out validateBuffer function

PR-URL: #17682 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
nodejs · Jan 11, 2018 · 8983405 · 8983405
1 parent fc8c1b1
commit 8983405
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -153,6 +153,15 @@ function makeCallback(cb) {
   };
 }
 
+function validateBuffer(buffer) {
+  if (!isUint8Array(buffer)) {
+    const err = new errors.TypeError('ERR_INVALID_ARG_TYPE', 'buffer',
+                                     ['Buffer', 'Uint8Array']);
+    Error.captureStackTrace(err, validateBuffer);
+    throw err;
+  }
+}
+
 function validateFd(fd) {
   let err;
 
@@ -745,9 +754,7 @@ fs.openSync = function(path, flags, mode) {
 
 fs.read = function(fd, buffer, offset, length, position, callback) {
   validateFd(fd);
-  if (!isUint8Array(buffer))
-    throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'buffer',
-                               ['Buffer', 'Uint8Array']);
+  validateBuffer(buffer);
 
   offset |= 0;
   length |= 0;
@@ -779,9 +786,7 @@ Object.defineProperty(fs.read, internalUtil.customPromisifyArgs,
 
 fs.readSync = function(fd, buffer, offset, length, position) {
   validateFd(fd);
-  if (!isUint8Array(buffer))
-    throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'buffer',
-                               ['Buffer', 'Uint8Array']);
+  validateBuffer(buffer);
 
   offset |= 0;
   length |= 0;