Skip to content

Commit

Permalink
benchmark: terminate child process on Windows
Browse files Browse the repository at this point in the history
test-benchmark-child-process failures reveal that
child-process-exec-stdout benchmark sometimes leaves around a stray
yes.exe process. Add code to terminate the process.

PR-URL: #12658
Ref: #12560
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
Trott authored and evanlucas committed May 2, 2017
1 parent e8ae4ba commit 780fa39
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
10 changes: 8 additions & 2 deletions benchmark/child_process/child-process-exec-stdout.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ const bench = common.createBenchmark(main, {
dur: [5]
});

const exec = require('child_process').exec;
const child_process = require('child_process');
const exec = child_process.exec;
function main(conf) {
bench.start();

Expand All @@ -28,7 +29,12 @@ function main(conf) {
});

setTimeout(function() {
child.kill();
bench.end(bytes);
if (process.platform === 'win32') {
// Sometimes there's a yes.exe process left hanging around on Windows...
child_process.execSync(`taskkill /f /t /pid ${child.pid}`);
} else {
child.kill();
}
}, dur * 1000);
}
1 change: 0 additions & 1 deletion test/sequential/sequential.status
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ prefix sequential
[true] # This section applies to all platforms

[$system==win32]
test-benchmark-child-process : PASS,FLAKY

[$system==linux]

Expand Down

0 comments on commit 780fa39

Please sign in to comment.