Skip to content

Commit

Permalink
assert: fix actual and expected order
Browse files Browse the repository at this point in the history
PR-URL: #15866
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
  • Loading branch information
skysteve authored and MylesBorins committed Nov 21, 2017
1 parent f037040 commit 38e58bf
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions test/parallel/test-vm-run-in-new-context.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ common.globalCheck = false;

// Run a string
const result = vm.runInNewContext('\'passed\';');
assert.strictEqual('passed', result);
assert.strictEqual(result, 'passed');

// Thrown error
assert.throws(() => {
Expand All @@ -21,7 +21,7 @@ assert.throws(() => {

global.hello = 5;
vm.runInNewContext('hello = 2');
assert.strictEqual(5, global.hello);
assert.strictEqual(global.hello, 5);


// Pass values in and out
Expand All @@ -33,9 +33,9 @@ global.obj = { foo: 0, baz: 3 };
/* eslint-disable no-unused-vars */
const baz = vm.runInNewContext(global.code, global.obj);
/* eslint-enable no-unused-vars */
assert.strictEqual(1, global.obj.foo);
assert.strictEqual(2, global.obj.bar);
assert.strictEqual(2, global.foo);
assert.strictEqual(global.obj.foo, 1);
assert.strictEqual(global.obj.bar, 2);
assert.strictEqual(global.foo, 2);

// Call a function by reference
function changeFoo() { global.foo = 100; }
Expand Down

0 comments on commit 38e58bf

Please sign in to comment.