test: add case for url.parse throwing a URIError

The auth property of a URL is decoded via decodeURIComponent, which can throw a URIError. The test URL here will trigger this. Adds documentation on the possible errors url.parse can throw. PR-URL: #12135 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Apr 4, 2017 · 2ff107d · 2ff107d
1 parent eefdf45
commit 2ff107d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/doc/api/url.md b/doc/api/url.md
@@ -259,6 +259,10 @@ added: v0.1.25
 The `url.parse()` method takes a URL string, parses it, and returns a URL
 object.
 
+A `TypeError` is thrown if `urlString` is not a string.
+
+A `URIError` is thrown if the `auth` property is present but cannot be decoded.
+
 ## url.resolve(from, to)
 <!-- YAML
 added: v0.1.25

diff --git a/test/parallel/test-url-parse-invalid-input.js b/test/parallel/test-url-parse-invalid-input.js
@@ -16,3 +16,5 @@ const url = require('url');
 ].forEach(function(val) {
   assert.throws(function() { url.parse(val); }, TypeError);
 });
+
+assert.throws(function() { url.parse('http://%E0%A4%A@fail'); }, /^URIError: URI malformed$/);