http: fix free http-parser too early

when the status code is 100 (Continue). Fixes #2636.
nodejs · Jan 30, 2012 · 3fd13c6 · 3fd13c6
1 parent b221fe9
commit 3fd13c6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/http.js b/lib/http.js
@@ -1169,7 +1169,11 @@ ClientRequest.prototype.onSocket = function(socket) {
           socket.destroy();
         }
         freeParser();
-      } else if (parser.incoming && parser.incoming.complete) {
+      } else if (parser.incoming && parser.incoming.complete &&
+                 // When the status code is 100 (Continue), the server will
+                 // send a final response after this client sends a request
+                 // body. So, we must not free the parser.
+                 parser.incoming.statusCode !== 100) {
         freeParser();
       }
     };

diff --git a/test/simple/test-http-expect-continue.js b/test/simple/test-http-expect-continue.js
@@ -44,7 +44,9 @@ server.on('checkContinue', function(req, res) {
   common.debug('Server got Expect: 100-continue...');
   res.writeContinue();
   sent_continue = true;
-  handler(req, res);
+  setTimeout(function() {
+    handler(req, res);
+  }, 100);
 });
 server.listen(common.PORT);