fix: enforce default for non-confirmation prompts #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
==========================================
+ Coverage 76.28% 76.36% +0.07%
==========================================
Files 21 21
Lines 1480 1485 +5
==========================================
+ Hits 1129 1134 +5
Misses 351 351
Continue to review full report at Codecov.
|
targos
reviewed
May 10, 2020
targos
reviewed
May 10, 2020
codebytere
force-pushed
the
default-answer-prompt
branch
from
c36e079
to
a473834
Compare
targos
approved these changes
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an edge case whereby if the user prompted for a
numberorinputtype and did not provide a default answer,prompt()would return true and like created a weird state.This fixes that by enforcing that if non-
confirmationprompts are invoked, a default is enforced. Also added tests to confirm correct behavior.cc @targos @joyeecheung