Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update prerequisite of git node v8 on macos #337

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

joyeecheung
Copy link
Member

cc @targos

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   75.75%   75.75%           
=======================================
  Files          21       21           
  Lines        1365     1365           
=======================================
  Hits         1034     1034           
  Misses        331      331

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aabb91...ddb2507. Read the comment docs.

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp. I don't use macOS

@joyeecheung joyeecheung merged commit 0179399 into nodejs:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants