Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specific getter forms #25

Merged
merged 5 commits into from
Oct 31, 2020
Merged

Support specific getter forms #25

merged 5 commits into from
Oct 31, 2020

Conversation

guybedford
Copy link
Collaborator

@guybedford guybedford commented Oct 31, 2020

As a follow up to the deprecation in #24, this is breaking some Babel strict mode outputs that use getters for named exports.

Instead, this PR detects very specific getter forms that are the common cases of a value definition or a getter returning either an identifier or a member expression only.

//cc @targos @nicolo-ribaudo @bmeck if any of you are interested in review here.

@guybedford guybedford merged commit 4c2b81c into master Oct 31, 2020
@guybedford guybedford deleted the getter-forms branch October 31, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant